From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Shawn Guo <shawn.guo@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v4 2/5] ASoC: Move standard kcontrol helpers to the component level
Date: Mon, 12 May 2014 15:09:09 +0100 [thread overview]
Message-ID: <20140512140909.GH25203@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140512110304.GB12304@sirena.org.uk>
On Mon, May 12, 2014 at 12:03:04PM +0100, Mark Brown wrote:
> On Mon, May 12, 2014 at 11:42:04AM +0100, Charles Keepax wrote:
>
> > > Yea, you're right. When the error message shows up, _regmap_read()
> > > returns -EBUSY for reg WM8962_CLASS_D_CONTROL_1. But how do I find out
> > > why the reg is not in the cache?
>
> > From what I can see it doesn't look like this register should be
> > volatile. I am checking with the hardware guys here, incase I am
> > missing something, but otherwise I will wing out a patch to make
> > it non-volatile.
>
> IIRC at least one of the bits in the register also appears in another
> register. They aren't volatile but the cache could get confused unless
> something is open coded to keep the two cached registers in sync.
Yup, just heard back from the hardware guys, this is exactly it.
The DAC_MUTE bit in registers R5 and R49 both control the same
thing. So if you change one it changes the other.
Looks like either something will need to be added to keep the two
registers in sync, or some manual caching of the speaker switch
until the device is enabled.
Thanks,
Charles
next prev parent reply other threads:[~2014-05-12 14:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:23 [PATCH v4 0/5] ASoC: Move IO and kcontrols to the component level Lars-Peter Clausen
2014-04-22 11:23 ` [PATCH v4 1/5] ASoC: Move IO abstraction " Lars-Peter Clausen
2014-04-22 12:24 ` Mark Brown
2014-04-22 11:23 ` [PATCH v4 2/5] ASoC: Move standard kcontrol helpers " Lars-Peter Clausen
2014-04-22 12:38 ` Mark Brown
2014-05-09 15:00 ` Shawn Guo
2014-05-09 15:17 ` Lars-Peter Clausen
2014-05-09 15:34 ` Fabio Estevam
2014-05-09 16:01 ` Lars-Peter Clausen
2014-05-09 16:11 ` Fabio Estevam
2014-05-10 5:07 ` Shawn Guo
2014-05-10 7:04 ` Lars-Peter Clausen
2014-05-10 7:11 ` Lars-Peter Clausen
2014-05-10 8:31 ` Shawn Guo
2014-05-10 8:37 ` Lars-Peter Clausen
2014-05-10 9:12 ` Shawn Guo
2014-05-10 9:28 ` Lars-Peter Clausen
2014-05-12 10:42 ` Charles Keepax
2014-05-12 11:03 ` Mark Brown
2014-05-12 14:09 ` Charles Keepax [this message]
2014-05-12 10:52 ` Charles Keepax
2014-05-13 3:19 ` Shawn Guo
2014-04-22 11:23 ` [PATCH v4 3/5] ASoC: Remove snd_soc_update_bits_locked() Lars-Peter Clausen
2014-04-22 12:25 ` Mark Brown
2014-04-22 11:23 ` [PATCH v4 4/5] ASoC: dapm: Rename soc_widget_update_bits_locked() to soc_widget_update_bits() Lars-Peter Clausen
2014-04-22 12:25 ` Mark Brown
2014-04-22 11:23 ` [PATCH v4 5/5] ASoC: Remove ASoC level IO tracing Lars-Peter Clausen
2014-04-22 12:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512140909.GH25203@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox