Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case
@ 2014-05-17 11:17 Axel Lin
  2014-05-19  7:41 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong registerforT5645_AIF2 case Oder Chiou
  2014-05-19 16:23 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-05-17 11:17 UTC (permalink / raw)
  To: Mark Brown; +Cc: Oder Chiou, Bard Liao, alsa-devel, Liam Girdwood

This looks like a copy-paste bug, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have this h/w, so please test if this patch works.
Axel
 sound/soc/codecs/rt5645.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 68923ec..ab97d72 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -1932,8 +1932,8 @@ static int rt5645_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 			RT5645_I2S_MS_MASK | RT5645_I2S_BP_MASK |
 			RT5645_I2S_DF_MASK, reg_val);
 		break;
-	case  RT5645_AIF2:
-		snd_soc_update_bits(codec, RT5645_I2S1_SDP,
+	case RT5645_AIF2:
+		snd_soc_update_bits(codec, RT5645_I2S2_SDP,
 			RT5645_I2S_MS_MASK | RT5645_I2S_BP_MASK |
 			RT5645_I2S_DF_MASK, reg_val);
 		break;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RFT] ASoC: rt5645: Fix updating wrong registerforT5645_AIF2 case
  2014-05-17 11:17 [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Axel Lin
@ 2014-05-19  7:41 ` Oder Chiou
  2014-05-19 16:23 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Oder Chiou @ 2014-05-19  7:41 UTC (permalink / raw)
  To: Axel Lin, Mark Brown
  Cc: Oder Chiou, Bard Liao, alsa-devel@alsa-project.org, Liam Girdwood

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@ingics.com]
> Sent: Saturday, May 17, 2014 7:18 PM
> To: Mark Brown
> Cc: Oder Chiou; Bard Liao; Liam Girdwood; alsa-devel@alsa-project.org
> Subject: [PATCH RFT] ASoC: rt5645: Fix updating wrong register forT5645_AIF2
> case
> 
> This looks like a copy-paste bug, fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have this h/w, so please test if this patch works.
> Axel
We've tested it, and it works properly, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case
  2014-05-17 11:17 [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Axel Lin
  2014-05-19  7:41 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong registerforT5645_AIF2 case Oder Chiou
@ 2014-05-19 16:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-19 16:23 UTC (permalink / raw)
  To: Axel Lin; +Cc: Oder Chiou, Bard Liao, alsa-devel, Liam Girdwood


[-- Attachment #1.1: Type: text/plain, Size: 120 bytes --]

On Sat, May 17, 2014 at 07:17:32PM +0800, Axel Lin wrote:
> This looks like a copy-paste bug, fix it.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-19 16:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17 11:17 [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Axel Lin
2014-05-19  7:41 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong registerforT5645_AIF2 case Oder Chiou
2014-05-19 16:23 ` [PATCH RFT] ASoC: rt5645: Fix updating wrong register for T5645_AIF2 case Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox