* [PATCH] ASoC: wm_adsp: Avoid attempt to free buffers that might still be in use
@ 2014-11-17 10:48 Charles Keepax
2014-11-17 14:22 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2014-11-17 10:48 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, patches, lgirdwood
We should not free any buffers associated with writing out coefficients
to the DSP until all the async writes have completed. This patch updates
the out of memory path when allocating a new buffer to include a call to
regmap_async_complete.
Reported-by: JS Park <aitdark.park@samsung.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm_adsp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 0a08ef5e..08d8ec3 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1343,6 +1343,7 @@ static int wm_adsp_load_coeff(struct wm_adsp *dsp)
file, blocks, pos - firmware->size);
out_fw:
+ regmap_async_complete(regmap);
release_firmware(firmware);
wm_adsp_buf_free(&buf_list);
out:
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm_adsp: Avoid attempt to free buffers that might still be in use
2014-11-17 10:48 [PATCH] ASoC: wm_adsp: Avoid attempt to free buffers that might still be in use Charles Keepax
@ 2014-11-17 14:22 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-11-17 14:22 UTC (permalink / raw)
To: Charles Keepax; +Cc: alsa-devel, patches, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]
On Mon, Nov 17, 2014 at 10:48:21AM +0000, Charles Keepax wrote:
> We should not free any buffers associated with writing out coefficients
> to the DSP until all the async writes have completed. This patch updates
> the out of memory path when allocating a new buffer to include a call to
> regmap_async_complete.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-17 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 10:48 [PATCH] ASoC: wm_adsp: Avoid attempt to free buffers that might still be in use Charles Keepax
2014-11-17 14:22 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox