* [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls
@ 2015-04-27 6:51 Axel Lin
2015-04-30 7:17 ` Philippe Rétornaz
2015-05-01 16:36 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-04-27 6:51 UTC (permalink / raw)
To: Mark Brown
Cc: Philippe Rétornaz, SaschaHauer, Steffen Trumtrar,
Liam Girdwood, alsa-devel@alsa-project.org
mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field.
Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL
bit.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have this h/w for test, so please help review and test this patch.
Thanks.
sound/soc/codecs/mc13783.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
index 2ffb9a0..3d44fc5 100644
--- a/sound/soc/codecs/mc13783.c
+++ b/sound/soc/codecs/mc13783.c
@@ -623,14 +623,14 @@ static int mc13783_probe(struct snd_soc_codec *codec)
AUDIO_SSI_SEL, 0);
else
mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_CODEC,
- 0, AUDIO_SSI_SEL);
+ AUDIO_SSI_SEL, AUDIO_SSI_SEL);
if (priv->dac_ssi_port == MC13783_SSI1_PORT)
mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC,
AUDIO_SSI_SEL, 0);
else
mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC,
- 0, AUDIO_SSI_SEL);
+ AUDIO_SSI_SEL, AUDIO_SSI_SEL);
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls
2015-04-27 6:51 [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls Axel Lin
@ 2015-04-30 7:17 ` Philippe Rétornaz
2015-05-01 16:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Rétornaz @ 2015-04-30 7:17 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: alsa-devel@alsa-project.org, Shawn Guo, SaschaHauer,
Liam Girdwood, Steffen Trumtrar, Fabio Estevam
Hello,
Le 27. 04. 15 08:51, Axel Lin a écrit :
> mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field.
> Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL
> bit.
>
I'm sorry but I don't have access to the hardware anymore.
Maybe Fabio Estevam or Shawn Guo can test it.
Regards,
Philippe
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls
2015-04-27 6:51 [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls Axel Lin
2015-04-30 7:17 ` Philippe Rétornaz
@ 2015-05-01 16:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-05-01 16:36 UTC (permalink / raw)
To: Axel Lin
Cc: Philippe Rétornaz, SaschaHauer, Steffen Trumtrar,
Liam Girdwood, alsa-devel@alsa-project.org
[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]
On Mon, Apr 27, 2015 at 02:51:35PM +0800, Axel Lin wrote:
> mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field.
> Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL
> bit.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-01 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-27 6:51 [PATCH RFT] ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls Axel Lin
2015-04-30 7:17 ` Philippe Rétornaz
2015-05-01 16:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox