Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits
@ 2015-05-15  1:15 Axel Lin
  2015-05-15  8:58 ` Charles Keepax
  2015-05-16 12:30 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-05-15  1:15 UTC (permalink / raw)
  To: Mark Brown
  Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Charles Keepax, Liam Girdwood

WM8955_K_8_0_MASK bits is controlled by WM8955_PLL_CONTROL_3 rather than
WM8955_PLL_CONTROL_2.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/wm8955.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
index f400d5c..08063a6 100644
--- a/sound/soc/codecs/wm8955.c
+++ b/sound/soc/codecs/wm8955.c
@@ -298,7 +298,7 @@ static int wm8955_configure_clocking(struct snd_soc_codec *codec)
 		snd_soc_update_bits(codec, WM8955_PLL_CONTROL_2,
 				    WM8955_K_17_9_MASK,
 				    (pll.k >> 9) & WM8955_K_17_9_MASK);
-		snd_soc_update_bits(codec, WM8955_PLL_CONTROL_2,
+		snd_soc_update_bits(codec, WM8955_PLL_CONTROL_3,
 				    WM8955_K_8_0_MASK,
 				    pll.k & WM8955_K_8_0_MASK);
 		if (pll.k)
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits
  2015-05-15  1:15 [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits Axel Lin
@ 2015-05-15  8:58 ` Charles Keepax
  2015-05-16 12:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2015-05-15  8:58 UTC (permalink / raw)
  To: Axel Lin
  Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood,
	patches@opensource.wolfsonmicro.com

On Fri, May 15, 2015 at 09:15:16AM +0800, Axel Lin wrote:
> WM8955_K_8_0_MASK bits is controlled by WM8955_PLL_CONTROL_3 rather than
> WM8955_PLL_CONTROL_2.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits
  2015-05-15  1:15 [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits Axel Lin
  2015-05-15  8:58 ` Charles Keepax
@ 2015-05-16 12:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-05-16 12:30 UTC (permalink / raw)
  To: Axel Lin
  Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Charles Keepax, Liam Girdwood


[-- Attachment #1.1: Type: text/plain, Size: 175 bytes --]

On Fri, May 15, 2015 at 09:15:16AM +0800, Axel Lin wrote:
> WM8955_K_8_0_MASK bits is controlled by WM8955_PLL_CONTROL_3 rather than
> WM8955_PLL_CONTROL_2.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-16 12:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-15  1:15 [PATCH] ASoC: wm8955: Fix setting wrong register for WM8955_K_8_0_MASK bits Axel Lin
2015-05-15  8:58 ` Charles Keepax
2015-05-16 12:30 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox