Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Krause <minipli@googlemail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	alsa-devel@alsa-project.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mathias Krause <minipli@googlemail.com>,
	Len Brown <lenb@kernel.org>
Subject: [PATCH 3/4] ASoC: rt5670: Constify ACPI device ids and register map
Date: Sat, 13 Jun 2015 14:25:15 +0200	[thread overview]
Message-ID: <1434198316-8400-4-git-send-email-minipli@googlemail.com> (raw)
In-Reply-To: <1434198316-8400-1-git-send-email-minipli@googlemail.com>

Constify the ACPI device ID array and the register map, no need to have
them writable at runtime. Also drop the unneeded RT5670_INIT_REG_LEN
define.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: Bard Liao <bardliao@realtek.com
---
 sound/soc/codecs/rt5670.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
index cc7f84a150a7..f87a6dabbd49 100644
--- a/sound/soc/codecs/rt5670.c
+++ b/sound/soc/codecs/rt5670.c
@@ -51,12 +51,11 @@ static const struct regmap_range_cfg rt5670_ranges[] = {
 	  .window_len = 0x1, },
 };
 
-static struct reg_default init_list[] = {
+static const struct reg_default init_list[] = {
 	{ RT5670_PR_BASE + 0x14, 0x9a8a },
 	{ RT5670_PR_BASE + 0x38, 0x3ba1 },
 	{ RT5670_PR_BASE + 0x3d, 0x3640 },
 };
-#define RT5670_INIT_REG_LEN ARRAY_SIZE(init_list)
 
 static const struct reg_default rt5670_reg[] = {
 	{ 0x00, 0x0000 },
@@ -2809,7 +2808,7 @@ static const struct i2c_device_id rt5670_i2c_id[] = {
 MODULE_DEVICE_TABLE(i2c, rt5670_i2c_id);
 
 #ifdef CONFIG_ACPI
-static struct acpi_device_id rt5670_acpi_match[] = {
+static const struct acpi_device_id rt5670_acpi_match[] = {
 	{ "10EC5670", 0},
 	{ },
 };
-- 
1.7.10.4

  parent reply	other threads:[~2015-06-13 12:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13 12:25 [PATCH 0/4] ASoC: constification patches Mathias Krause
2015-06-13 12:25 ` [PATCH 1/4] ASoC: max98090: Constify ACPI device ids and register map Mathias Krause
2015-06-13 12:25 ` [PATCH 2/4] ASoC: rt5640: " Mathias Krause
2015-06-15 10:19   ` Mark Brown
2015-06-15 17:50     ` Mathias Krause
2015-06-13 12:25 ` Mathias Krause [this message]
2015-06-13 12:25 ` [PATCH 4/4] ASoC: intel: Constify ACPI device ids Mathias Krause
2015-06-15 13:07   ` Jarkko Nikula
2015-06-15 10:32 ` [PATCH 0/4] ASoC: constification patches Mark Brown
2015-06-15 17:59   ` Mathias Krause
2015-06-15 19:17     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434198316-8400-4-git-send-email-minipli@googlemail.com \
    --to=minipli@googlemail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lenb@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox