From: Mark Brown <broonie@kernel.org>
To: Mathias Krause <minipli@googlemail.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2/4] ASoC: rt5640: Constify ACPI device ids and register map
Date: Mon, 15 Jun 2015 11:19:40 +0100 [thread overview]
Message-ID: <20150615101940.GH18309@sirena.org.uk> (raw)
In-Reply-To: <1434198316-8400-3-git-send-email-minipli@googlemail.com>
[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]
On Sat, Jun 13, 2015 at 02:25:14PM +0200, Mathias Krause wrote:
> Constify the ACPI device ID array and the register map, no need to have
> them writable at runtime. Also drop the unneeded RT5640_INIT_REG_LEN
> define.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: Bard Liao <bardliao@realtek.com
> Cc: Oder Chiou <oder_chiou@realtek.com>
Please don't include stuff like this in the commit log if you're not
using it - you've CCed Oder but not Bard here (you should be CCing him).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-06-15 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 12:25 [PATCH 0/4] ASoC: constification patches Mathias Krause
2015-06-13 12:25 ` [PATCH 1/4] ASoC: max98090: Constify ACPI device ids and register map Mathias Krause
2015-06-13 12:25 ` [PATCH 2/4] ASoC: rt5640: " Mathias Krause
2015-06-15 10:19 ` Mark Brown [this message]
2015-06-15 17:50 ` Mathias Krause
2015-06-13 12:25 ` [PATCH 3/4] ASoC: rt5670: " Mathias Krause
2015-06-13 12:25 ` [PATCH 4/4] ASoC: intel: Constify ACPI device ids Mathias Krause
2015-06-15 13:07 ` Jarkko Nikula
2015-06-15 10:32 ` [PATCH 0/4] ASoC: constification patches Mark Brown
2015-06-15 17:59 ` Mathias Krause
2015-06-15 19:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615101940.GH18309@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=minipli@googlemail.com \
--cc=oder_chiou@realtek.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox