Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/6] Remove redundant spi driver bus initialization
@ 2015-06-23 14:45 Antonio Borneo
  2015-06-23 14:52 ` [PATCH 1/6] ASoC: wm0010: " Antonio Borneo
  0 siblings, 1 reply; 4+ messages in thread
From: Antonio Borneo @ 2015-06-23 14:45 UTC (permalink / raw)
  To: Alan Ott, Alexander Aring, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
	Andrzej Hajda, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
	Greg Kroah-Hartman, Jaroslav Kysela, Jonathan Cameron, Kalle Valo,
	Karol Wrona, Kyungmin Park, Lars-Peter Clausen, Liam Girdwood,
	linux-iio-u79uwXL29TY76Z2rM5mHXA,
	linux-media-u79uwXL29TY76Z2rM5mHXA,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	linux-wpan-u79uwXL29TY76Z2rM5mHXA, Mark Brown,
	Mauro Carvalho Chehab, netdev-u79uwXL29TY76Z2rM5mHXA,
	patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
	Solomon Peachy, Takashi Iwai, Varka Bhadram
  Cc: Antonio Borneo, linux-kernel-u79uwXL29TY76Z2rM5mHXA

This cleanup was already completed between end 2011 and early 2012
with a patch series from Lars-Peter Clausen:
https://lkml.org/lkml/2011/11/24/190

Later on new redundant initialization re-appeared here and there.
Time to cleanup again.

And, yes, I'm lazy! I copy-paste the exact same commit message from
Lars-Peter; only minor reformat to stay in 75 char/line and fix the
name of spi_register_driver().

Regards,
Antonio

Antonio Borneo (6):
  ASoC: wm0010: Remove redundant spi driver bus initialization
  iio: ssp_sensors: Remove redundant spi driver bus initialization
  staging: mt29f_spinand: Remove redundant spi driver bus initialization
  net: ieee802154: Remove redundant spi driver bus initialization
  wireless: cw1200: Remove redundant spi driver bus initialization
  [media] s5c73m3: Remove redundant spi driver bus initialization

 drivers/iio/common/ssp_sensors/ssp_dev.c      | 1 -
 drivers/media/i2c/s5c73m3/s5c73m3-spi.c       | 1 -
 drivers/net/ieee802154/cc2520.c               | 1 -
 drivers/net/ieee802154/mrf24j40.c             | 1 -
 drivers/net/wireless/cw1200/cw1200_spi.c      | 1 -
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 -
 sound/soc/codecs/wm0010.c                     | 1 -
 7 files changed, 7 deletions(-)

-- 
2.4.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/6] ASoC: wm0010: Remove redundant spi driver bus initialization
  2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
@ 2015-06-23 14:52 ` Antonio Borneo
  2015-06-24  8:24   ` Charles Keepax
  2015-07-03 14:10   ` Applied "ASoC: wm0010: Remove redundant spi driver bus initialization" to the asoc tree Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Antonio Borneo @ 2015-06-23 14:52 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown,
	alsa-devel, patches
  Cc: Antonio Borneo

In ancient times it was necessary to manually initialize the bus
field of an spi_driver to spi_bus_type. These days this is done in
spi_register_driver(), so we can drop the manual assignment.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
To: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <lgirdwood@gmail.com>
To: Mark Brown <broonie@kernel.org>
To: alsa-devel@alsa-project.org
To: patches@opensource.wolfsonmicro.com
Cc: linux-kernel@vger.kernel.org
---
 sound/soc/codecs/wm0010.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index f37989e..61bfff4 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -1005,7 +1005,6 @@ static int wm0010_spi_remove(struct spi_device *spi)
 static struct spi_driver wm0010_spi_driver = {
 	.driver = {
 		.name	= "wm0010",
-		.bus 	= &spi_bus_type,
 		.owner	= THIS_MODULE,
 	},
 	.probe		= wm0010_spi_probe,
-- 
2.4.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] ASoC: wm0010: Remove redundant spi driver bus initialization
  2015-06-23 14:52 ` [PATCH 1/6] ASoC: wm0010: " Antonio Borneo
@ 2015-06-24  8:24   ` Charles Keepax
  2015-07-03 14:10   ` Applied "ASoC: wm0010: Remove redundant spi driver bus initialization" to the asoc tree Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2015-06-24  8:24 UTC (permalink / raw)
  To: Antonio Borneo
  Cc: alsa-devel, Takashi Iwai, patches, Liam Girdwood, Mark Brown

On Tue, Jun 23, 2015 at 10:52:12PM +0800, Antonio Borneo wrote:
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
> 
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> To: Jaroslav Kysela <perex@perex.cz>
> To: Takashi Iwai <tiwai@suse.de>
> To: Liam Girdwood <lgirdwood@gmail.com>
> To: Mark Brown <broonie@kernel.org>
> To: alsa-devel@alsa-project.org
> To: patches@opensource.wolfsonmicro.com
> Cc: linux-kernel@vger.kernel.org
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Applied "ASoC: wm0010: Remove redundant spi driver bus initialization" to the asoc tree
  2015-06-23 14:52 ` [PATCH 1/6] ASoC: wm0010: " Antonio Borneo
  2015-06-24  8:24   ` Charles Keepax
@ 2015-07-03 14:10   ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-07-03 14:10 UTC (permalink / raw)
  To: Antonio Borneo, Charles Keepax, Mark Brown; +Cc: alsa-devel

The patch

   ASoC: wm0010: Remove redundant spi driver bus initialization

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 7a28db9906a993ec43226fb6927f35b8af6cc83c Mon Sep 17 00:00:00 2001
From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Tue, 23 Jun 2015 22:52:12 +0800
Subject: [PATCH] ASoC: wm0010: Remove redundant spi driver bus initialization

In ancient times it was necessary to manually initialize the bus
field of an spi_driver to spi_bus_type. These days this is done in
spi_register_driver(), so we can drop the manual assignment.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm0010.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index f37989e..61bfff4 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -1005,7 +1005,6 @@ static int wm0010_spi_remove(struct spi_device *spi)
 static struct spi_driver wm0010_spi_driver = {
 	.driver = {
 		.name	= "wm0010",
-		.bus 	= &spi_bus_type,
 		.owner	= THIS_MODULE,
 	},
 	.probe		= wm0010_spi_probe,
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-03 14:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
2015-06-23 14:52 ` [PATCH 1/6] ASoC: wm0010: " Antonio Borneo
2015-06-24  8:24   ` Charles Keepax
2015-07-03 14:10   ` Applied "ASoC: wm0010: Remove redundant spi driver bus initialization" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox