From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Michal Marek <mmarek@suse.cz>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH 1/3] Revert "ASoC: wm0010: Add missing IRQF_ONESHOT"
Date: Thu, 02 Jul 2015 21:26:44 +0800 [thread overview]
Message-ID: <1435843604.17967.1.camel@ingics.com> (raw)
This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT").
The coccinelle warnings is false positive because the original code does
set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;".
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/wm0010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 6560a66..ff924032 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -953,7 +953,7 @@ static int wm0010_spi_probe(struct spi_device *spi)
trigger = IRQF_TRIGGER_FALLING;
trigger |= IRQF_ONESHOT;
- ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT,
+ ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
"wm0010", wm0010);
if (ret) {
dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
--
2.1.0
next reply other threads:[~2015-07-02 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:26 Axel Lin [this message]
2015-07-02 13:27 ` [PATCH 2/3] Revert "ASoC: wm5100: Pass the IRQF_ONESHOT flag" Axel Lin
2015-07-02 13:29 ` [PATCH 3/3] Revert "ASoC: wm8996: " Axel Lin
2015-07-08 18:34 ` Mark Brown
2015-07-09 1:52 ` Axel Lin
2015-07-09 8:27 ` Mark Brown
2015-07-07 9:58 ` [PATCH 1/3] Revert "ASoC: wm0010: Add missing IRQF_ONESHOT" Charles Keepax
2015-07-07 13:50 ` Fabio Estevam
2015-07-08 18:50 ` Applied "ASoC: wm0010: Remove spurious missing IRQF_ONESHOT" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435843604.17967.1.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=fengguang.wu@intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox