From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Applied "ASoC: wm0010: Remove spurious missing IRQF_ONESHOT" to the asoc tree
Date: Wed, 08 Jul 2015 19:50:57 +0100 [thread overview]
Message-ID: <E1ZCuQr-0004tX-38@debutante> (raw)
In-Reply-To: <1435843604.17967.1.camel@ingics.com>
The patch
ASoC: wm0010: Remove spurious missing IRQF_ONESHOT
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 030e6ee241f0586308622bcdd273a317976b3169 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Thu, 2 Jul 2015 21:26:44 +0800
Subject: [PATCH] ASoC: wm0010: Remove spurious missing IRQF_ONESHOT
This reverts 58d468328646 ("ASoC: wm0010: Add missing IRQF_ONESHOT").
The coccinelle warnings is false positive because the original code does
set IRQF_ONESHOT by "trigger |= IRQF_ONESHOT;".
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/wm0010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index e1da49f39334..f2c6ad4b8fde 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -953,7 +953,7 @@ static int wm0010_spi_probe(struct spi_device *spi)
trigger = IRQF_TRIGGER_FALLING;
trigger |= IRQF_ONESHOT;
- ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT,
+ ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
"wm0010", wm0010);
if (ret) {
dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
--
2.1.4
prev parent reply other threads:[~2015-07-08 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:26 [PATCH 1/3] Revert "ASoC: wm0010: Add missing IRQF_ONESHOT" Axel Lin
2015-07-02 13:27 ` [PATCH 2/3] Revert "ASoC: wm5100: Pass the IRQF_ONESHOT flag" Axel Lin
2015-07-02 13:29 ` [PATCH 3/3] Revert "ASoC: wm8996: " Axel Lin
2015-07-08 18:34 ` Mark Brown
2015-07-09 1:52 ` Axel Lin
2015-07-09 8:27 ` Mark Brown
2015-07-07 9:58 ` [PATCH 1/3] Revert "ASoC: wm0010: Add missing IRQF_ONESHOT" Charles Keepax
2015-07-07 13:50 ` Fabio Estevam
2015-07-08 18:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ZCuQr-0004tX-38@debutante \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).