From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Belisko <marek.belisko@streamunlimited.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: [PATCH 2/2] ASoC: pcm1681: Improve the logic for de-emphasis sampling rate selection
Date: Thu, 23 Jul 2015 23:23:35 +0800 [thread overview]
Message-ID: <1437665015.20606.6.camel@ingics.com> (raw)
In-Reply-To: <1437664946.20606.5.camel@ingics.com>
Slightly improve the logic for de-emphasis sampling rate selection by break
out the loop if the rate is matched.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/pcm1681.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
index 1011142..5832523 100644
--- a/sound/soc/codecs/pcm1681.c
+++ b/sound/soc/codecs/pcm1681.c
@@ -95,17 +95,22 @@ static int pcm1681_set_deemph(struct snd_soc_codec *codec)
struct pcm1681_private *priv = snd_soc_codec_get_drvdata(codec);
int i = 0, val = -1, enable = 0;
- if (priv->deemph)
- for (i = 0; i < ARRAY_SIZE(pcm1681_deemph); i++)
- if (pcm1681_deemph[i] == priv->rate)
+ if (priv->deemph) {
+ for (i = 0; i < ARRAY_SIZE(pcm1681_deemph); i++) {
+ if (pcm1681_deemph[i] == priv->rate) {
val = i;
+ break;
+ }
+ }
+ }
if (val != -1) {
regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
PCM1681_DEEMPH_RATE_MASK, val << 3);
enable = 1;
- } else
+ } else {
enable = 0;
+ }
/* enable/disable deemphasis functionality */
return regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
--
2.1.0
next prev parent reply other threads:[~2015-07-23 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:22 [PATCH 1/2] ASoC: pcm1681: Fix setting de-emphasis sampling rate selection Axel Lin
2015-07-23 15:23 ` Axel Lin [this message]
2015-07-23 19:48 ` [PATCH 2/2] ASoC: pcm1681: Improve the logic for " Marek Belisko
2015-07-24 1:17 ` Axel Lin
2015-07-24 5:22 ` Marek Belisko
2015-07-24 5:48 ` Axel Lin
2015-07-24 12:07 ` Marek Belisko
2015-07-24 11:31 ` Applied "ASoC: pcm1681: Improve the logic for de-emphasis sampling rate selection" to the asoc tree Mark Brown
2015-07-23 19:46 ` [PATCH 1/2] ASoC: pcm1681: Fix setting de-emphasis sampling rate selection Marek Belisko
2015-07-24 11:31 ` Applied "ASoC: pcm1681: Fix setting de-emphasis sampling rate selection" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437665015.20606.6.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=marek.belisko@streamunlimited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox