From: Marek Belisko <marek.belisko@streamunlimited.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: pcm1681: Fix setting de-emphasis sampling rate selection
Date: Thu, 23 Jul 2015 21:46:39 +0200 [thread overview]
Message-ID: <55B1449F.3040603@streamunlimited.com> (raw)
In-Reply-To: <1437664946.20606.5.camel@ingics.com>
On 23.07.2015 17:22, Axel Lin wrote:
> The de-emphasis sampling rate selection is controlled by BIT[3:4] of
> PCM1681_DEEMPH_CONTROL register. Do proper left shift to set it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> sound/soc/codecs/pcm1681.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
> index b2c990f..1011142 100644
> --- a/sound/soc/codecs/pcm1681.c
> +++ b/sound/soc/codecs/pcm1681.c
> @@ -102,7 +102,7 @@ static int pcm1681_set_deemph(struct snd_soc_codec *codec)
>
> if (val != -1) {
> regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
> - PCM1681_DEEMPH_RATE_MASK, val);
> + PCM1681_DEEMPH_RATE_MASK, val << 3);
Good catch. Acked-by: Marek Belisko <marek.belisko@streamunlimited.com>
> enable = 1;
> } else
> enable = 0;
>
next prev parent reply other threads:[~2015-07-23 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:22 [PATCH 1/2] ASoC: pcm1681: Fix setting de-emphasis sampling rate selection Axel Lin
2015-07-23 15:23 ` [PATCH 2/2] ASoC: pcm1681: Improve the logic for " Axel Lin
2015-07-23 19:48 ` Marek Belisko
2015-07-24 1:17 ` Axel Lin
2015-07-24 5:22 ` Marek Belisko
2015-07-24 5:48 ` Axel Lin
2015-07-24 12:07 ` Marek Belisko
2015-07-24 11:31 ` Applied "ASoC: pcm1681: Improve the logic for de-emphasis sampling rate selection" to the asoc tree Mark Brown
2015-07-23 19:46 ` Marek Belisko [this message]
2015-07-24 11:31 ` Applied "ASoC: pcm1681: Fix setting " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B1449F.3040603@streamunlimited.com \
--to=marek.belisko@streamunlimited.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox