Re: Regression in Traktor Audio10 driver (snd-usb-audio) mixer flags

[Owen Williams <owilliams@mixxx.org>]

Yes, that does allow me to use the mixer flags again.  However I notice
when I connect the device it no longer starts up with the flags in the
default state I can specify when I connect the card to my mac -- is
that the resume functionality that's supposed to work?


On Tue, 2016-01-12 at 23:17 +0100, Takashi Iwai wrote:
> On Tue, 12 Jan 2016 22:24:41 +0100,
> Owen Williams wrote:
> > 
> > Finally found the bad commit:
> > SHA da6d276957ea56b9514aa5c8d885edf22f0b3e65
> > ALSA: usb-audio: Add resume support for Native Instruments controls
> 
> Great, thanks for spotting out!
> 
> > I did upgrade my firmware at some point, perhaps the newer firmware
> > changed how this works.  Happy to test whatever patches against a
> > newer
> > kernel (I'm on Wily, so 4.2.0-23).
> 
> Could you try the patch below?
> 
> 
> Takashi
> 
> ---
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 0ce888dceed0..279025650568 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -793,7 +793,7 @@ static int
> snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol,
>  		return 0;
>  
>  	kcontrol->private_value &= ~(0xff << 24);
> -	kcontrol->private_value |= newval;
> +	kcontrol->private_value |= (unsigned int)newval << 24;
>  	err = snd_ni_update_cur_val(list);
>  	return err < 0 ? err : 1;
>  }
> 
>