From: Takashi Iwai <tiwai@suse.de>
To: Owen Williams <owilliams@mixxx.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: Regression in Traktor Audio10 driver (snd-usb-audio) mixer flags
Date: Tue, 12 Jan 2016 23:17:20 +0100 [thread overview]
Message-ID: <s5h1t9mo32n.wl-tiwai@suse.de> (raw)
In-Reply-To: <1452633881.10729.31.camel@legoogs.cam.corp.google.com>
On Tue, 12 Jan 2016 22:24:41 +0100,
Owen Williams wrote:
>
> Finally found the bad commit:
> SHA da6d276957ea56b9514aa5c8d885edf22f0b3e65
> ALSA: usb-audio: Add resume support for Native Instruments controls
Great, thanks for spotting out!
> I did upgrade my firmware at some point, perhaps the newer firmware
> changed how this works. Happy to test whatever patches against a newer
> kernel (I'm on Wily, so 4.2.0-23).
Could you try the patch below?
Takashi
---
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 0ce888dceed0..279025650568 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -793,7 +793,7 @@ static int snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol,
return 0;
kcontrol->private_value &= ~(0xff << 24);
- kcontrol->private_value |= newval;
+ kcontrol->private_value |= (unsigned int)newval << 24;
err = snd_ni_update_cur_val(list);
return err < 0 ? err : 1;
}
next prev parent reply other threads:[~2016-01-12 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 18:26 Regression in Traktor Audio10 driver (snd-usb-audio) mixer flags Owen Williams
2016-01-08 14:18 ` Owen Williams
2016-01-09 7:42 ` Takashi Iwai
2016-01-10 20:20 ` Owen Williams
2016-01-12 6:22 ` Takashi Iwai
2016-01-12 21:24 ` Owen Williams
2016-01-12 22:17 ` Takashi Iwai [this message]
2016-01-13 4:23 ` Owen Williams
2016-01-13 6:39 ` Takashi Iwai
2016-01-13 14:58 ` Owen Williams
2016-01-13 15:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1t9mo32n.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=owilliams@mixxx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox