From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com, broonie@kernel.org,
jeremy@jcline.org, liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH 1/3] [PATCH] ASoC: acpi: fix machine driver selection based on quirk
Date: Thu, 04 Jan 2018 15:08:49 +0200 [thread overview]
Message-ID: <1515071329.7000.668.camel@linux.intel.com> (raw)
In-Reply-To: <20180103170242.5363-2-pierre-louis.bossart@linux.intel.com>
On Wed, 2018-01-03 at 11:02 -0600, Pierre-Louis Bossart wrote:
> The ACPI/machine-driver code refactoring introduced in 4.13 introduced
> a regression for cases where we need a DMI-based quirk to select the
> machine driver (the BIOS reports an invalid HID). The fix is just to
> make sure the results of the quirk are actually used.
>
> for (mach = machines; mach->id[0]; mach++) {
> if (snd_soc_acpi_check_hid(mach->id) == true) {
> if (mach->machine_quirk(mach) != NULL)
Just a nit: perhaps use more natural style, i.e. drop " != NULL" part
off?
> + mach = mach->machine_quirk(mach);
> + return mach;
> }
> }
> return NULL;
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-04 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 17:02 [PATCH 0/3] ASoC: Intel: ACPI-related fixes Pierre-Louis Bossart
2018-01-03 17:02 ` [PATCH 1/3] [PATCH] ASoC: acpi: fix machine driver selection based on quirk Pierre-Louis Bossart
2018-01-04 13:08 ` Andy Shevchenko [this message]
2018-01-04 15:18 ` Pierre-Louis Bossart
2018-01-05 0:58 ` Pierre-Louis Bossart
2018-01-03 17:02 ` [PATCH 2/3] ASoC: Replace snd_soc_acpi_check_hid with acpi_dev_present Pierre-Louis Bossart
2018-01-04 13:09 ` Andy Shevchenko
2018-01-03 17:02 ` [PATCH 3/3] ASoC: Intel: bytcht_es8316: fix HID handling Pierre-Louis Bossart
2018-01-04 14:57 ` Andy Shevchenko
2018-01-04 15:24 ` Pierre-Louis Bossart
2018-01-04 16:00 ` Andy Shevchenko
2018-01-04 17:06 ` Pierre-Louis Bossart
2018-01-04 17:13 ` Andy Shevchenko
2018-01-12 21:09 ` Applied "ASoC: Intel: bytcht_es8316: fix HID handling" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515071329.7000.668.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeremy@jcline.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox