* Fix latency error check in pulse_delay()
[not found] <alsa-project/alsa-plugins/pr/66@alsa-project.org>
@ 2026-09-21 0:12 ` GitHub pull_request - opened
0 siblings, 0 replies; 2+ messages in thread
From: GitHub pull_request - opened @ 2026-09-21 0:12 UTC (permalink / raw)
To: alsa-devel
alsa-project/alsa-plugins pull request #66 was opened from argothiel:
There seems to be an issue with `pulse_delay()` which calls `pa_stream_get_latency()`. PulseAudio documents that this function returns `-PA_ERR_NODATA` when timing information is not available yet. The ALSA Pulse plugin compares the result against positive `PA_ERR_NODATA`; it therefore treats that temporary condition as an unrelated failure and returns `-EIO`.
Change `PA_ERR_NODATA` to `-PA_ERR_NODATA` in the comparison to not miss that branch.
Fixes #65.
Request URL : https://github.com/alsa-project/alsa-plugins/pull/66
Patch URL : https://github.com/alsa-project/alsa-plugins/pull/66.patch
Repository URL: https://github.com/alsa-project/alsa-plugins
^ permalink raw reply [flat|nested] 2+ messages in thread
* Fix latency error check in pulse_delay()
[not found] <alsa-project/alsa-plugins/pr/67@alsa-project.org>
@ 2026-09-21 0:30 ` GitHub pull_request - opened
0 siblings, 0 replies; 2+ messages in thread
From: GitHub pull_request - opened @ 2026-09-21 0:30 UTC (permalink / raw)
To: alsa-devel
alsa-project/alsa-plugins pull request #67 was opened from argothiel:
There is an issue with `pulse_delay()` which calls `pa_stream_get_latency()`. PulseAudio documents that this function returns `-PA_ERR_NODATA` when timing information is not available yet. The ALSA Pulse plugin compares the result against positive `PA_ERR_NODATA`; it therefore treats that temporary condition as an unrelated failure and returns `-EIO`.
Change `PA_ERR_NODATA` to `-PA_ERR_NODATA` in the comparison to not miss that branch.
Fixes #65.
Request URL : https://github.com/alsa-project/alsa-plugins/pull/67
Patch URL : https://github.com/alsa-project/alsa-plugins/pull/67.patch
Repository URL: https://github.com/alsa-project/alsa-plugins
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-21 0:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alsa-project/alsa-plugins/pr/66@alsa-project.org>
2026-09-21 0:12 ` Fix latency error check in pulse_delay() GitHub pull_request - opened
[not found] <alsa-project/alsa-plugins/pr/67@alsa-project.org>
2026-09-21 0:30 ` GitHub pull_request - opened
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox