From: Alien <alien999999999@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Igor Kovalenko <garrison@mail.ru>,
openvortex-dev@nongnu.org, Raymond <rayau@netvigator.com>,
alsa-devel@lists.sourceforge.net
Subject: Re: [Openvortex-dev] Re: Re: [ALSA - driver 0001138]: errors when installing au8820 modules
Date: Wed, 8 Jun 2005 13:13:46 +0200 [thread overview]
Message-ID: <200506081313.48981.alien999999999@users.sourceforge.net> (raw)
In-Reply-To: <s5hacm1kv7f.wl@alsa2.suse.de>
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
Op woensdag 8 juni 2005 12:18, schreef Takashi Iwai:
> At Tue, 7 Jun 2005 20:02:47 +0200,
>
> Alien wrote:
> > this is a patch against some CVS version of a few weeks ago not more than
> > 3 weeks i think...
>
> The patch looks almost fine to me.
>
> Just subtle things:
> > @@ -202,6 +205,10 @@
> > goto alloc_out;
> > }
> >
> > + snd_card_set_dev(card, &pci->dev);
> > +
> > + snd_card_set_dev(card, &pci->dev);
> > +
> > *rchip = chip;
>
> Too much :)
>
> > Index: alsa-kernel/pci/au88x0/au88x0_eqdata.c
> > ===================================================================
> > RCS file: /cvsroot/alsa/alsa-kernel/pci/au88x0/au88x0_eqdata.c,v
> > retrieving revision 1.1
> > diff -u -r1.1 au88x0_eqdata.c
> > --- alsa-kernel/pci/au88x0/au88x0_eqdata.c 9 Mar 2004 11:52:13 -0000 1.1
> > +++ alsa-kernel/pci/au88x0/au88x0_eqdata.c 7 Jun 2005 17:56:37 -0000
> > @@ -104,7 +104,11 @@
> > };
> >
> > /*_rodataba0:*/
> > -static long eq_levels[32] = {
> > +static u16 eq_levels[64] = {
> > + 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > + 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > + 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > + 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> > 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
>
> You don't need to define values if the static array is initialize to
> zero. In this case,
>
> static u16 eq_levels[64];
>
> would be better.
>
>
> Takashi
you sure that this will initialize to 0 ? i seem to remember that C doesn't
init arrays to 0... unless there's a memset somewhere, of course, i never
wrote kernel stuff...
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-06-08 11:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 20:22 [ALSA - driver 0001138]: errors when installing au8820 modules bugtrack
2005-06-06 2:09 ` Raymond
2005-06-06 15:49 ` Takashi Iwai
2005-06-07 15:05 ` Raymond
2005-06-07 15:16 ` Alien
2005-06-07 16:29 ` Takashi Iwai
2005-06-07 17:05 ` [Openvortex-dev] " Igor Kovalenko
2005-06-07 17:17 ` Alien
2005-06-07 17:38 ` Igor Kovalenko
2005-06-07 18:02 ` Alien
2005-06-08 10:18 ` Takashi Iwai
2005-06-08 11:13 ` Alien [this message]
2005-06-08 12:12 ` Takashi Iwai
2005-06-08 13:29 ` Alien
2005-06-08 13:41 ` Takashi Iwai
2005-06-08 18:09 ` Igor Kovalenko
2005-06-08 11:40 ` Raymond
2005-06-08 12:19 ` Takashi Iwai
2005-06-08 18:12 ` Igor Kovalenko
2005-06-09 8:13 ` Raymond
2005-06-08 12:34 ` Raymond
2005-06-08 12:43 ` Takashi Iwai
2005-06-08 18:03 ` Igor Kovalenko
2005-06-09 8:54 ` Raymond
2005-06-28 7:50 ` Raymond
2005-07-01 19:03 ` Igor Kovalenko
2005-07-02 12:53 ` Raymond
2005-07-14 16:43 ` Igor Kovalenko
2005-06-08 9:06 ` Raymond
2005-06-08 10:22 ` Takashi Iwai
2005-06-09 8:34 ` Raymond
2005-06-09 10:17 ` [Openvortex-dev] " Igor Kovalenko
2005-06-12 15:18 ` Raymond
2005-06-10 7:35 ` Raymond
2005-06-10 10:33 ` Takashi Iwai
2005-06-10 11:28 ` Raymond
2005-07-29 14:43 ` Raymond
2005-07-29 15:09 ` Takashi Iwai
2005-08-05 12:46 ` Raymond
2005-08-05 14:32 ` Takashi Iwai
[not found] ` <43067D3B.5040601@netvigator.com>
2005-08-21 12:41 ` Takashi Iwai
2005-08-23 15:20 ` Raymond
2005-08-23 17:18 ` Takashi Iwai
2005-08-23 21:40 ` Alien
2005-08-24 10:35 ` Takashi Iwai
2005-08-25 17:12 ` Raymond
2005-08-25 17:43 ` Alien
2005-08-26 9:01 ` Raymond
2005-08-25 18:58 ` Manuel Jander
2005-08-25 20:04 ` Alien
2005-06-08 10:23 ` Alien
2005-06-09 8:49 ` Raymond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506081313.48981.alien999999999@users.sourceforge.net \
--to=alien999999999@users.sourceforge.net \
--cc=alsa-devel@lists.sourceforge.net \
--cc=garrison@mail.ru \
--cc=openvortex-dev@nongnu.org \
--cc=rayau@netvigator.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox