Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jin-Young Park <mcjin02@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: wrong print debugging message code
Date: Mon, 23 Jun 2008 19:51:01 +0100	[thread overview]
Message-ID: <20080623185100.GA31751@sirena.org.uk> (raw)
In-Reply-To: <280b69ac0806231118n2349bedbl1b9462ecd5f1ecf3@mail.gmail.com>

On Tue, Jun 24, 2008 at 03:18:49AM +0900, Jin-Young Park wrote:

> I defined "#define XXXX_DEBUG 0" and dbg() put into mute
> function(wm8960_digital_mute()).

The WM8960 driver isn't in the standard Linux kernel yet, it is currently
distributed via the Wolfson web site.  None of the drivers included in
the standard Linux kernel were using their dbg() macros, though some had
such macros present.

> I think, it maybe potential that reduce performance before one knows.

The performance impact should be very minor - the digital mute is not
used in any hot paths and the output will only go do the dmesg buffer by
default so won't have the overhead of writing to the console.

Out of interest, which platform are you working with?

  reply	other threads:[~2008-06-23 18:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-21  5:44 wrong print debugging message code Jin-Young Park
2008-06-23 10:55 ` Takashi Iwai
2008-06-23 11:12   ` Mark Brown
2008-06-23 12:13     ` Takashi Iwai
2008-06-23 12:17       ` Mark Brown
2008-06-23 18:18   ` Jin-Young Park
2008-06-23 18:51     ` Mark Brown [this message]
2008-06-24  5:55       ` Jin-Young Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080623185100.GA31751@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=mcjin02@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox