Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Marek Vasut <marek.vasut@gmail.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] ASoC: Add Palm/PXA27x unified ASoC audio driver
Date: Wed, 5 Nov 2008 21:54:56 +0000	[thread overview]
Message-ID: <20081105215456.GA11921@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hhc6lhpw6.wl%tiwai@suse.de>

On Wed, Nov 05, 2008 at 09:35:53PM +0100, Takashi Iwai wrote:

> > +#ifdef CONFIG_SND_PXA2XX_SOC_PALM27X
> > +void __init palm27x_asoc_set_pdata(struct palm27x_asoc_info *data);

> I wonder whether it's really __init.

Yes.  This will be set up by the machine init code which has to be built
in.  It should be platform data but we can't support that yet.

> Note that the driver can be a module in theory.

Yeah, that practice won't actually build so should probably be masked
out in Kconfig.

  reply	other threads:[~2008-11-05 21:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 18:52 [PATCH 0/4] ASoC updates Mark Brown
2008-11-05 18:53 ` [PATCH 1/4] ASoC: TLV320AIC23B Support more sample rates Mark Brown
2008-11-05 18:53   ` [PATCH 2/4] ASoC: Add Palm/PXA27x unified ASoC audio driver Mark Brown
2008-11-05 18:53     ` [PATCH 3/4] ASoC: Remove core version number Mark Brown
2008-11-05 18:53       ` [PATCH 4/4] ASoC: Add new parameter to s3c24xx_pcm_enqueue Mark Brown
2008-11-05 19:35     ` [PATCH 2/4] ASoC: Add Palm/PXA27x unified ASoC audio driver Marek Vasut
2008-11-05 20:35     ` Takashi Iwai
2008-11-05 21:54       ` Mark Brown [this message]
2008-11-05 20:35   ` [PATCH 1/4] ASoC: TLV320AIC23B Support more sample rates Takashi Iwai
2008-11-05 22:05     ` Mark Brown
2008-11-06 23:11       ` [PATCH 1/1] [ALSA] " Troy Kisky
2008-11-07 14:10         ` Mark Brown
2008-11-06 10:49     ` [PATCH 1/4] " Mark Brown
2008-11-06 11:03       ` Takashi Iwai
2008-11-06 11:23   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081105215456.GA11921@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=marek.vasut@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox