Re: [PATCH 2/4] ASoC: Add Palm/PXA27x unified ASoC audio driver

[Takashi Iwai <tiwai@suse.de>]

At Wed,  5 Nov 2008 18:53:29 +0000,
Mark Brown wrote:
> 
> From: Marek Vasut <marek.vasut@gmail.com>
> 
> this patch adds asoc audio driver for pxa27x based Palm PDAs. I tested it for
> palmtx, t5 and ld, it should work with palmz72 as well (slapin, please test).
> I sent it here some time ago, but now I got to fixing bugs in it. It should
> be somehow mostly ok and ready for applying.
> 
> [Converted to use snd_soc_dapm_nc_pin() -- broonie]
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  arch/arm/mach-pxa/include/mach/palmasoc.h |   13 ++
>  sound/soc/pxa/Kconfig                     |    9 +
>  sound/soc/pxa/Makefile                    |    2 +
>  sound/soc/pxa/palm27x.c                   |  269 +++++++++++++++++++++++++++++
>  4 files changed, 293 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-pxa/include/mach/palmasoc.h
>  create mode 100644 sound/soc/pxa/palm27x.c
> 
> diff --git a/arch/arm/mach-pxa/include/mach/palmasoc.h b/arch/arm/mach-pxa/include/mach/palmasoc.h
> new file mode 100644
> index 0000000..6c4b1f7
> --- /dev/null
> +++ b/arch/arm/mach-pxa/include/mach/palmasoc.h
> @@ -0,0 +1,13 @@
> +#ifndef _INCLUDE_PALMASOC_H_
> +#define _INCLUDE_PALMASOC_H_
> +struct palm27x_asoc_info {
> +	int	jack_gpio;
> +};
> +
> +#ifdef CONFIG_SND_PXA2XX_SOC_PALM27X
> +void __init palm27x_asoc_set_pdata(struct palm27x_asoc_info *data);

I wonder whether it's really __init.
Note that the driver can be a module in theory.


Takashi