From: Mark Brown <broonie@sirena.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Christian Pellegrin <chripell@gmail.com>,
Christian Pellegrin <chripell@fsfe.org>
Subject: Re: [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix
Date: Wed, 12 Nov 2008 15:25:50 +0000 [thread overview]
Message-ID: <20081112152549.GH8767@sirena.org.uk> (raw)
In-Reply-To: <s5hvdutht53.wl%tiwai@suse.de>
On Wed, Nov 12, 2008 at 04:16:08PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > The global variable is used to tell the DMA driver how to set the
> > hardware up for the port. Since the variable is tied to the underlying
> > hardware channel it's used for there's no real win from duplicating it
> > into a variable - the hardware it is used to configure can't be shared.
> I know it, but it's still uncomfortable that such secret mythes and
> legends are underlying without explanation. Could you add some more
> comments around that code to avoid misunderstanding by readers?
Hrm, that's a fairly standard idiom for ASoC DMA/DAI driver interaction
so probably more of a Documentation/ thing but doing it there is not too
helpful for addressing your concern. I'll have a think.
next prev parent reply other threads:[~2008-11-12 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 11:55 [PATCH 0/4] ASoC updates Mark Brown
2008-11-12 11:55 ` [PATCH 1/4] ASoC: TLV320AIC23B Support more sample rates Mark Brown
2008-11-12 11:55 ` [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix Mark Brown
2008-11-12 11:55 ` [PATCH 3/4] ASoC: Add Right-Justified mode and Codec clock master to davinci-i2s Mark Brown
2008-11-12 11:55 ` [PATCH 4/4] ASoC: DaVinci: Audio: Fix swapping of channels at start of stereo playback Mark Brown
2008-11-12 12:33 ` [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix Takashi Iwai
2008-11-12 15:10 ` Mark Brown
2008-11-12 15:16 ` Takashi Iwai
2008-11-12 15:25 ` Mark Brown [this message]
2008-11-12 14:19 ` Ben Dooks
2008-11-12 14:21 ` Takashi Iwai
2008-11-12 14:59 ` Mark Brown
2008-11-12 17:29 ` christian pellegrin
2008-11-12 12:31 ` [PATCH 0/4] ASoC updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112152549.GH8767@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=chripell@fsfe.org \
--cc=chripell@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox