From: Mark Brown <broonie@sirena.org.uk>
To: naveen krishna ch <naveenkrishna.ch@gmail.com>
Cc: alsa-devel@alsa-project.org, Steve Sakoman <steve@sakoman.com>
Subject: Re: Kcontrols for ASoC TWL4030 CODEC
Date: Thu, 20 Nov 2008 13:36:45 +0000 [thread overview]
Message-ID: <20081120133644.GE4539@sirena.org.uk> (raw)
In-Reply-To: <ef0d8a250811200442j3146441cgc4650153974e62d6@mail.gmail.com>
On Thu, Nov 20, 2008 at 06:12:56PM +0530, naveen krishna ch wrote:
> static const struct snd_kcontrol_new twl4030_snd_controls[] = {
> - SOC_DOUBLE_R("Master Playback Volume",
> - TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> - 0, 127, 0),
> - SOC_DOUBLE_R("Capture Volume",
> - TWL4030_REG_ATXL1PGA, TWL4030_REG_ATXR1PGA,
> - 0, 127, 0),
> +
> + /* Master Playback Volume Controls */
> + SOC_DOUBLE_R("Master PLayback Course Gain",
> + TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> + 6, 3, 0),
> +
Please see the comments I made in response to your original posting -
there look to be problems with your indentation here and your control
names should conform to the ALSA control naming standard in:
Documentation/sound/alsa/ControlNames.txt
next prev parent reply other threads:[~2008-11-20 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 12:42 Kcontrols for ASoC TWL4030 CODEC naveen krishna ch
2008-11-20 13:36 ` Mark Brown [this message]
2008-11-20 14:01 ` naveen krishna ch
2008-11-20 14:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120133644.GE4539@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox