Re: Kcontrols for ASoC TWL4030 CODEC

["naveen krishna ch" <naveenkrishna.ch@gmail.com>]

On Thu, Nov 20, 2008 at 7:06 PM, Mark Brown <broonie@sirena.org.uk> wrote:

> On Thu, Nov 20, 2008 at 06:12:56PM +0530, naveen krishna ch wrote:
>
> >  static const struct snd_kcontrol_new twl4030_snd_controls[] = {
> > -    SOC_DOUBLE_R("Master Playback Volume",
> > -         TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> > -        0, 127, 0),
> > -    SOC_DOUBLE_R("Capture Volume",
> > -         TWL4030_REG_ATXL1PGA, TWL4030_REG_ATXR1PGA,
> > -        0, 127, 0),
> > +
> > +    /* Master Playback Volume Controls */
> > +        SOC_DOUBLE_R("Master PLayback Course Gain",
> > +                TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> > +                6, 3, 0),
> > +
>
> Please see the comments I made in response to your original posting -
> there look to be problems with your indentation here and your control
> names should conform to the ALSA control naming standard in:

Sorry i could not solve the issue with the indentation i have attached the
patch  file.

>
>
>        Documentation/sound/alsa/ControlNames.txt

The standard names in the documentation does not gives the exact details of
the CODEC's feature so i used a part of the CODEC pin name to avoid
confusion at later stages.

Course and Fine controls are feature given by the CODEC so distinguish them
i named them against the features.
There is an internal and external speaker facility i name d them against
that.

However i will re submit the patch with some modifications in names.

-- 
Thanks,

(: Naveen Krishna Ch :)