From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@sirena.org.uk>
Cc: sakoman@gmail.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs
Date: Mon, 8 Dec 2008 13:40:05 +0200 [thread overview]
Message-ID: <200812081340.05602.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20081208112847.GE5159@sirena.org.uk>
Hello,
On Monday 08 December 2008 13:28:48 ext Mark Brown wrote:
> On Mon, Dec 08, 2008 at 10:09:05AM +0200, Peter Ujfalusi wrote:
> > +static const char *twl4030_predrivel_texts[] =
> > + {"Off", "DACL1 Switch", "DACL2 Switch", "Invalid",
> > + "DACR2 Switch"};
>
> Why the "Switch" in the option names - I'd expect to see it omitted.
They will be gone.
> Does the "Invalid" option work well in applications like alsamixer?
Not quite well, the outmixer_event will just plain forbits the Invalid
combination (returns -1, which should have been -EINVAL). In alsamixer you
can not really select the "DACR2". With amixer you can.
I have been wondering about this for a while but could not find a better
solution, yet.
--
Péter
next prev parent reply other threads:[~2008-12-08 11:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 8:09 [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback) Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 1/8] ASoC: TWL4030: Correct DAPM_DAC with power control Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 2/8] ASoC: TWL4030: Add Analog PGA control switch to DAPM Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 3/8] ASoC: TWL4030: Add DAPM event handler for output MUX selection Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 4/8] ASoC: TWL4030: DAPM mapping of the Earpiece output Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 6/8] ASoC: TWL4030: DAPM mapping of the Headset outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 7/8] ASoC: TWL4030: DAPM mapping of the Carkit outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 8/8] ASoC: TWL4030: DAPM mapping of the Handsfree outputs Peter Ujfalusi
2008-12-08 11:28 ` [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs Mark Brown
2008-12-08 11:40 ` Peter Ujfalusi [this message]
2008-12-08 13:50 ` Mark Brown
2008-12-08 11:24 ` [PATCH 4/8] ASoC: TWL4030: DAPM mapping of the Earpiece output Mark Brown
2008-12-08 11:23 ` [PATCH 2/8] ASoC: TWL4030: Add Analog PGA control switch to DAPM Mark Brown
2008-12-08 12:06 ` Peter Ujfalusi
2008-12-08 12:35 ` Mark Brown
2008-12-08 11:31 ` [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback) Mark Brown
2008-12-08 13:20 ` Mark Brown
2008-12-09 6:51 ` Peter Ujfalusi
2008-12-09 9:47 ` Mark Brown
2008-12-09 10:07 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812081340.05602.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox