From: Mark Brown <broonie@sirena.org.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: sakoman@gmail.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback)
Date: Mon, 8 Dec 2008 11:31:39 +0000 [thread overview]
Message-ID: <20081208113138.GF5159@sirena.org.uk> (raw)
In-Reply-To: <1228723748-22911-1-git-send-email-peter.ujfalusi@nokia.com>
On Mon, Dec 08, 2008 at 10:09:00AM +0200, Peter Ujfalusi wrote:
> Peter Ujfalusi (8):
> ASoC: TWL4030: Correct DAPM_DAC with power control
> ASoC: TWL4030: Add Analog PGA control switch to DAPM
> ASoC: TWL4030: Add DAPM event handler for output MUX selection
> ASoC: TWL4030: DAPM mapping of the Earpiece output
> ASoC: TWL4030: DAPM mapping of the PreDriv outputs
> ASoC: TWL4030: DAPM mapping of the Headset outputs
> ASoC: TWL4030: DAPM mapping of the Carkit outputs
> ASoC: TWL4030: DAPM mapping of the Handsfree outputs
This series looks basically good - I've commented on a few issues in the
individual patches and I'd also note that you seem to be using
"controls" to refer to the single control for muxes in most of the
patches, which is a little confusing.
next prev parent reply other threads:[~2008-12-08 11:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 8:09 [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback) Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 1/8] ASoC: TWL4030: Correct DAPM_DAC with power control Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 2/8] ASoC: TWL4030: Add Analog PGA control switch to DAPM Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 3/8] ASoC: TWL4030: Add DAPM event handler for output MUX selection Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 4/8] ASoC: TWL4030: DAPM mapping of the Earpiece output Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 6/8] ASoC: TWL4030: DAPM mapping of the Headset outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 7/8] ASoC: TWL4030: DAPM mapping of the Carkit outputs Peter Ujfalusi
2008-12-08 8:09 ` [PATCH 8/8] ASoC: TWL4030: DAPM mapping of the Handsfree outputs Peter Ujfalusi
2008-12-08 11:28 ` [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs Mark Brown
2008-12-08 11:40 ` Peter Ujfalusi
2008-12-08 13:50 ` Mark Brown
2008-12-08 11:24 ` [PATCH 4/8] ASoC: TWL4030: DAPM mapping of the Earpiece output Mark Brown
2008-12-08 11:23 ` [PATCH 2/8] ASoC: TWL4030: Add Analog PGA control switch to DAPM Mark Brown
2008-12-08 12:06 ` Peter Ujfalusi
2008-12-08 12:35 ` Mark Brown
2008-12-08 11:31 ` Mark Brown [this message]
2008-12-08 13:20 ` [PATCH 0/8] ASoC: TWL4030: DAPM implementation for outputs (playback) Mark Brown
2008-12-09 6:51 ` Peter Ujfalusi
2008-12-09 9:47 ` Mark Brown
2008-12-09 10:07 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208113138.GF5159@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox