From: David Brownell <david-b@pacbell.net>
To: "Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface
Date: Thu, 26 Feb 2009 10:52:10 -0800 [thread overview]
Message-ID: <200902261052.10647.david-b@pacbell.net> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705EC8B1C03@dlee07.ent.ti.com>
On Wednesday 25 February 2009, Lopez Cruz, Misael wrote:
> + unsigned int gpio;
Use "int" not unsigned for such might-be-a-GPIO codes ...
> + unsigned int irq;
> + unsigned long irqflags;
> + irq_handler_t handler;
> + struct work_struct work;
> };
>
> +#define NO_JACK_PIN_GPIO UINT_MAX
And any negative number to flag "no GPIO";
"-EINVAL" for example.
> + if (pins[i].gpio != NO_JACK_PIN_GPIO) {
Make that: if (gpio_is_valid(pins[i].gpio)) ...
prev parent reply other threads:[~2009-02-26 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 7:57 [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface Lopez Cruz, Misael
2009-02-26 11:52 ` [alsa-devel] " Mark Brown
2009-02-27 10:52 ` Lopez Cruz, Misael
2009-02-27 13:05 ` Mark Brown
2009-03-02 1:54 ` Lopez Cruz, Misael
2009-03-02 11:38 ` [alsa-devel] " Mark Brown
2009-03-02 21:16 ` Lopez Cruz, Misael
2009-03-02 22:55 ` [alsa-devel] " Mark Brown
2009-03-03 0:03 ` Lopez Cruz, Misael
2009-03-03 0:43 ` [alsa-devel] " Mark Brown
2009-03-03 0:47 ` Lopez Cruz, Misael
2009-02-26 18:52 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902261052.10647.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox