Re: [PATCH 1/1] ASoC: TWL4030: Add support Voice DAI

[Mark Brown <broonie@sirena.org.uk>]

On Fri, Apr 10, 2009 at 11:03:42AM +0900, Joonyoung Shim wrote:
> On 4/9/2009 11:06 PM, Mark Brown wrote:

> >> +	if (infreq != TWL4030_APLL_INFREQ_26000KHZ)
> >> +		return -EPERM;

> > It's probably worth a comment here telling users that they'll need to
> > call set_sysclk() in their init() function rather than hw_params() -
> > otherwise this might get called before the clock is set up.

> It seems better that i remove startup function and add set_sysclk function,
> and inform supporting only 26MHz system master clock through comment. 
> i think it is not important where set_sysclk() is called, the voice PCM
> interface needs just 26MHz system master clock.

It does feel right to have some sort of check for a valid sysclk so that
there's some software level documentation for the requirement since it's
easy to set up an ASoC driver without reading the datasheet for the part
so it's helpful if the driver can flag up broken configurations to them.

The reason for worrying about where set_sysclk() is called from is that
if you are going to have a check like that the user needs to call
set_sysclk() before the check is performed to ensure that the correct
configuration has been applied.