From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@sirena.org.uk>
Cc: "kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Joonyoung Shim <jy0922.shim@samsung.com>,
"bhmin@samsung.com" <bhmin@samsung.com>
Subject: Re: [PATCH 1/1] ASoC: TWL4030: Add support Voice DAI
Date: Tue, 14 Apr 2009 10:09:52 +0300 [thread overview]
Message-ID: <200904141009.52450.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20090409140654.GC18152@sirena.org.uk>
On Thursday 09 April 2009 17:06:54 ext Mark Brown wrote:
> On Thu, Apr 09, 2009 at 10:54:37PM +0900, Joonyoung Shim wrote:
>
> > + /* change rate and set CODECPDZ */
> > + twl4030_codec_enable(codec, 0);
> > + twl4030_write(codec, TWL4030_REG_CODEC_MODE, mode);
> > + twl4030_codec_enable(codec, 1);
>
> Hrm. This codec_enable() call looks fishy - what's the effect if the
> other DAI is running when the voice DAI is configured? Though there may
> be no way round this...
The TRM is not that clear on what changes in the CODEC_MODE register needs a
codec reset. Changing the OPT_MODE does need a reset, most probably other
fields also..
--
Péter
next prev parent reply other threads:[~2009-04-14 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 13:54 [PATCH 1/1] ASoC: TWL4030: Add support Voice DAI Joonyoung Shim
2009-04-09 14:06 ` Mark Brown
2009-04-10 2:03 ` Joonyoung Shim
2009-04-10 10:22 ` Mark Brown
2009-04-14 7:09 ` Peter Ujfalusi [this message]
2009-04-14 7:07 ` Peter Ujfalusi
2009-04-20 5:31 ` Joonyoung Shim
2009-04-20 6:35 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904141009.52450.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhmin@samsung.com \
--cc=broonie@sirena.org.uk \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox