From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: grant.likely@secretlab.ca, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 4/4] Rename exports in mpc5200_dma.c
Date: Mon, 27 Apr 2009 20:35:34 +0100 [thread overview]
Message-ID: <20090427193534.GA23567@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090427164447.18211.42851.stgit@terra>
On Mon, Apr 27, 2009 at 12:44:47PM -0400, Jon Smirl wrote:
> Rename the public DMA exports into the global name space so that the DMA code can be built as a module.
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_startup);
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_hw_free);
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_trigger);
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_shutdown);
Why are you exporting these? They should all be accessed via...
> -struct snd_soc_platform psc_dma_pcm_soc_platform = {
> +struct snd_soc_platform mpc5200_audio_dma_platform = {
> .name = "mpc5200-psc-audio",
> .pcm_ops = &psc_dma_pcm_ops,
> .pcm_new = &psc_dma_pcm_new,
> .pcm_free = &psc_dma_pcm_free,
> };
> -
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_platform);
...this unless there's a reason not to do so.
> -int psc_dma_startup(struct snd_pcm_substream *substream,
> +int mpc5200_audio_dma_startup(struct snd_pcm_substream *substream,
> struct snd_soc_dai *dai);
These should go.
next prev parent reply other threads:[~2009-04-27 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 16:44 [PATCH v2 0/4] Mark mpc5200 i2s driver BROKEN Jon Smirl
2009-04-27 16:44 ` [PATCH v2 1/4] Set the MPC5200 i2s driver to BROKEN status Jon Smirl
2009-04-27 16:44 ` [PATCH v2 2/4] Basic split of mpc5200 DMA code out from mpc5200_psc_i2s Jon Smirl
2009-04-27 16:44 ` [PATCH v2 3/4] Rename the PSC functions to DMA Jon Smirl
2009-04-27 16:44 ` [PATCH v2 4/4] Rename exports in mpc5200_dma.c Jon Smirl
2009-04-27 19:35 ` Mark Brown [this message]
2009-04-27 20:05 ` Jon Smirl
2009-04-27 20:09 ` Mark Brown
2009-04-27 21:43 ` Jon Smirl
2009-04-28 1:19 ` Jon Smirl
2009-04-27 16:53 ` [PATCH v2 0/4] Mark mpc5200 i2s driver BROKEN Grant Likely
2009-04-27 19:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427193534.GA23567@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=grant.likely@secretlab.ca \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox