From: Mark Brown <broonie@sirena.org.uk>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: grant.likely@secretlab.ca, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 4/4] Rename exports in mpc5200_dma.c
Date: Mon, 27 Apr 2009 21:09:10 +0100 [thread overview]
Message-ID: <20090427200910.GC14626@sirena.org.uk> (raw)
In-Reply-To: <9e4733910904271305h171f5e9dybdd560ae2c22c9bf@mail.gmail.com>
On Mon, Apr 27, 2009 at 04:05:10PM -0400, Jon Smirl wrote:
> On Mon, Apr 27, 2009 at 3:35 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > Why are you exporting these? ?They should all be accessed via...
> This is part of what is broken in the driver. I have later patches
> that fix it but those patches are more complex.
Could you go into more detail on this, please? Why aren't you just
moving them directly to the vtable of the DMA driver?
next prev parent reply other threads:[~2009-04-27 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 16:44 [PATCH v2 0/4] Mark mpc5200 i2s driver BROKEN Jon Smirl
2009-04-27 16:44 ` [PATCH v2 1/4] Set the MPC5200 i2s driver to BROKEN status Jon Smirl
2009-04-27 16:44 ` [PATCH v2 2/4] Basic split of mpc5200 DMA code out from mpc5200_psc_i2s Jon Smirl
2009-04-27 16:44 ` [PATCH v2 3/4] Rename the PSC functions to DMA Jon Smirl
2009-04-27 16:44 ` [PATCH v2 4/4] Rename exports in mpc5200_dma.c Jon Smirl
2009-04-27 19:35 ` Mark Brown
2009-04-27 20:05 ` Jon Smirl
2009-04-27 20:09 ` Mark Brown [this message]
2009-04-27 21:43 ` Jon Smirl
2009-04-28 1:19 ` Jon Smirl
2009-04-27 16:53 ` [PATCH v2 0/4] Mark mpc5200 i2s driver BROKEN Grant Likely
2009-04-27 19:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427200910.GC14626@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=grant.likely@secretlab.ca \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox