From: Daniel Mack <daniel@caiaq.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support
Date: Thu, 4 Jun 2009 15:12:25 +0200 [thread overview]
Message-ID: <20090604131225.GL26688@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090604123632.GC11496@sirena.org.uk>
On Thu, Jun 04, 2009 at 01:36:32PM +0100, Mark Brown wrote:
> On Wed, Jun 03, 2009 at 08:33:42PM +0800, Eric Miao wrote:
> > Make the pxa I2S configuration generic, add support for Left_J, add
> > support for variable frame width like 32fs, 48fs, 64fs and 96fs
>
> I'm OK with this from a code review point of view providing Daniel is
> happy from a testing point of view. I'll need to fire up my Zylonite
> and test on that as well - I'll update the machine driver as required
> assuming everything works OK.
I'll need some time to test that. Hope to get back to you soon.
Daniel
next prev parent reply other threads:[~2009-06-04 13:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 12:33 [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support Eric Miao
2009-06-03 13:18 ` Daniel Mack
2009-06-03 14:22 ` Eric Miao
2009-06-03 14:23 ` Mark Brown
2009-06-03 14:24 ` Daniel Mack
[not found] ` <37b631400906040207o169abbc2ob33100879ac68911@mail.gmail.com>
2009-06-04 9:44 ` Paul Shen
2009-06-05 17:26 ` Daniel Mack
2009-06-05 22:47 ` Mark Brown
2009-06-04 12:36 ` Mark Brown
2009-06-04 13:12 ` Daniel Mack [this message]
2009-06-06 8:26 ` Daniel Ribeiro
2009-06-09 9:39 ` Paul Shen
2009-06-09 9:54 ` Daniel Mack
2009-06-09 10:10 ` Daniel Ribeiro
2009-06-06 20:12 ` Mark Brown
2009-06-08 12:12 ` pHilipp Zabel
2009-06-08 12:40 ` Mark Brown
2009-06-08 15:58 ` pHilipp Zabel
2009-06-08 16:25 ` Daniel Ribeiro
2009-06-08 16:38 ` Mark Brown
2009-06-08 17:18 ` pHilipp Zabel
2009-06-08 17:41 ` Mark Brown
2009-06-08 18:59 ` pHilipp Zabel
2009-06-08 16:03 ` Daniel Ribeiro
2009-06-08 16:53 ` Mark Brown
2009-06-08 17:26 ` Daniel Ribeiro
2009-06-08 18:06 ` Mark Brown
2009-06-08 20:52 ` Daniel Ribeiro
2009-06-09 9:39 ` Eric Miao
2009-06-09 9:41 ` Eric Miao
2009-06-09 9:58 ` Mark Brown
2009-06-09 11:40 ` pHilipp Zabel
2009-06-10 22:24 ` Daniel Ribeiro
2009-06-11 9:00 ` Mark Brown
2009-06-11 15:13 ` Daniel Mack
2009-06-11 13:34 ` Eric Miao
2009-06-11 14:36 ` [RFC] I2S and LEFT_J (was: ASoC: pxa-ssp: enhance I2S and add Left_J support) Daniel Ribeiro
2009-06-15 8:45 ` Eric Miao
2009-06-15 14:57 ` Daniel Ribeiro
2009-06-15 15:04 ` Mark Brown
2009-06-15 17:20 ` Daniel Ribeiro
2009-06-15 17:40 ` Daniel Mack
2009-06-16 2:11 ` Daniel Ribeiro
2009-06-15 18:00 ` Mark Brown
2009-06-18 7:58 ` [RFC] I2S and LEFT_J Eric Miao
2009-06-18 12:30 ` Daniel Ribeiro
2009-06-22 22:14 ` Daniel Mack
2009-06-27 0:28 ` Daniel Ribeiro
2009-07-01 12:17 ` Daniel Mack
2009-06-08 21:07 ` [RFC] Auto setup TDM when needed. Add frame_width and rx/tx masks to set_tdm_slots Daniel Ribeiro
2009-06-09 9:10 ` Mark Brown
2009-06-08 14:13 ` [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support Eric Miao
2009-06-08 15:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604131225.GL26688@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox