From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Dooks <ben@simtec.co.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: tlv320aic3x: Allow driver to use already registered i2c device
Date: Fri, 7 Aug 2009 10:43:01 +0100 [thread overview]
Message-ID: <20090807094301.GA639@sirena.org.uk> (raw)
In-Reply-To: <20090806230204.992074844@fluff.org.uk>
On Fri, Aug 07, 2009 at 12:02:05AM +0100, Ben Dooks wrote:
> Add the ability for the driver to use an already registered i2c device
> instead of creating one of them itself. Add the field i2c_already field
> to the setup data and not set the i2c bus address the driver will then
> use the device already setup.
Why would you want to do this? I suspect that perhaps you want to
convert the driver to use the standard device model instead but without
understanding your motivation for making this change it is very hard to
comment in detail.
> --- a/sound/soc/codecs/tlv320aic3x.c 2009-08-06 11:53:30.000000000 +0100
> +++ b/sound/soc/codecs/tlv320aic3x.c 2009-08-06 15:29:45.000000000 +0100
> @@ -1310,6 +1310,7 @@ static int aic3x_i2c_remove(struct i2c_c
>
> static const struct i2c_device_id aic3x_i2c_id[] = {
> { "tlv320aic3x", 0 },
> + { "tlv320aic33", 0 },
> { }
> };
This is a reasonable but unrelated change.
next prev parent reply other threads:[~2009-08-07 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:02 tlv320aic3x: Allow driver to use already registered i2c device Ben Dooks
2009-08-07 9:43 ` Mark Brown [this message]
[not found] ` <4A84148E.7050307@simtec.co.uk>
2009-08-13 13:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807094301.GA639@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).