From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Dooks <ben@simtec.co.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: tlv320aic3x: Allow driver to use already registered i2c device
Date: Thu, 13 Aug 2009 14:48:27 +0100 [thread overview]
Message-ID: <20090813134827.GE21652@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4A84148E.7050307@simtec.co.uk>
On Thu, Aug 13, 2009 at 02:26:38PM +0100, Ben Dooks wrote:
> Mark Brown wrote:
> >Why would you want to do this? I suspect that perhaps you want to
> >convert the driver to use the standard device model instead but without
> >understanding your motivation for making this change it is very hard to
> >comment in detail.
> The device is registered by the code that sets the initial devices
> up that have been passed from the bootloader, thus the tlv320aic33
> fails to initialise as there is already an i2c device on the i2c bus
> when it comes along.
OK, that's what I thought. You need to convert the driver to use the
normal device model probe methods rather than using bodges like this.
See drivers like wm8731 for an example of how the conversion looks.
prev parent reply other threads:[~2009-08-13 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:02 tlv320aic3x: Allow driver to use already registered i2c device Ben Dooks
2009-08-07 9:43 ` Mark Brown
[not found] ` <4A84148E.7050307@simtec.co.uk>
2009-08-13 13:48 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813134827.GE21652@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox