Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	e3-hacking@earth.li
Subject: Re: [PATCH] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1
Date: Wed, 21 Oct 2009 22:16:07 +0300	[thread overview]
Message-ID: <20091021221607.c46f60e3.jhnikula@gmail.com> (raw)
In-Reply-To: <200910212035.42245.jkrzyszt@tis.icnet.pl>

On Wed, 21 Oct 2009 20:35:40 +0200
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:

>  
> +	if (cpu_class_is_omap1())
> +		return 0;
> +
>  	omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
>  	omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
>  
I would have implemented this by "if (!cpu_class_is_omap1())
{..._burst_mode}" for making sure that no new OMAP1 error is introduced
in the future if there is need to add some common stuff after those
burst_mode calls and probably compiler can better optimize away those
burst_mode calls for OMAP1 builds.

-- 
Jarkko

  reply	other threads:[~2009-10-21 19:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 18:35 [PATCH] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1 Janusz Krzysztofik
2009-10-21 19:16 ` Jarkko Nikula [this message]
2009-10-21 21:10   ` [PATCH v2] " Janusz Krzysztofik
2009-10-22  6:16     ` Jarkko Nikula
2009-10-22 10:50     ` Mark Brown
2009-11-05 18:03       ` Janusz Krzysztofik
2009-11-06 11:17         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091021221607.c46f60e3.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=e3-hacking@earth.li \
    --cc=jkrzyszt@tis.icnet.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox