Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1
Date: Thu, 22 Oct 2009 11:50:40 +0100	[thread overview]
Message-ID: <20091022105040.GA18862@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200910212310.05087.jkrzyszt@tis.icnet.pl>

On Wed, Oct 21, 2009 at 11:10:03PM +0200, Janusz Krzysztofik wrote:
> Wednesday 21 October 2009 21:16:07 Jarkko Nikula napisał(a):
> >
> > I would have implemented this by "if (!cpu_class_is_omap1())
> > {..._burst_mode}" for making sure that no new OMAP1 error is introduced
> > in the future if there is need to add some common stuff after those
> > burst_mode calls and probably compiler can better optimize away those
> > burst_mode calls for OMAP1 builds.
> 
> Yes, you're right.
> 
> --------------------------

Applied, thanks.  For ease of use with tools like git am it's nicer if
you can include text like the above which shouldn't be in the actual
commit log after the --- (where the diffstat ends up).
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2009-10-22 10:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 18:35 [PATCH] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1 Janusz Krzysztofik
2009-10-21 19:16 ` Jarkko Nikula
2009-10-21 21:10   ` [PATCH v2] " Janusz Krzysztofik
2009-10-22  6:16     ` Jarkko Nikula
2009-10-22 10:50     ` Mark Brown [this message]
2009-11-05 18:03       ` Janusz Krzysztofik
2009-11-06 11:17         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091022105040.GA18862@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jkrzyszt@tis.icnet.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox