Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Shane W" <shane-alsa@csy.ca>,
	"David Härdeman" <david@hardeman.nu>
Subject: Re: [PATCH 00/11] Intel HDMI fixes
Date: Wed, 18 Nov 2009 12:35:10 +0800	[thread overview]
Message-ID: <20091118043510.GB8665@localhost> (raw)
In-Reply-To: <s5h8we7kcku.wl%tiwai@suse.de>

On Sun, Nov 15, 2009 at 11:54:57PM +0800, Takashi Iwai wrote:
> At Sun, 15 Nov 2009 19:32:19 +0800,
> Wu Fengguang wrote:
> > 
> > Hi Takashi,
> > 
> > Here is some Intel HDMI fixes, most of them are inspired/written by
> > David Härdeman (Big thanks!).
> > 
> > - fix audio infoframe size
> > - sticky infoframe/stream id/channel count to
> >   - not disturb (David's) fragile devices
> >   - avoid the first 0.5s audio samples be losted
> > - avoid losing presence info during
> >   - module reloading (by querying the pin sense status)
> >   - power off (by disabling it)
> 
> Thanks for the patches!
> 
> Most of them look good; however, I'm not much convinced wrt the
> disablement of power-saving.  In many cases, the power-saving is more 
> important than 0.5sec drop-out (particularly if it's already fixed in
> the succeeding playbacks).  Thus disabling the power-saving
> unconditionally is no good idea.
> 
> Maybe some flag, either an option or a mixer control, would be
> preferred for defining the behavior, as a compromise...

OK. I'll do this in a separate patch.

> Also, it'd be more readable if we define another common jack
> detection routine that calls the pin sense function, such as
> 
> int snd_hda_jack_detect(struct hda_codec *codc, hda_nid_t nid)
> {
> 	u32 sense = snd_hda_pin_sense(codec, nid);
> 	return !!(sense & AC_PINSENSE_PRESENCE);
> }
> 
> since all callers check only that bit.
> 
> Last but not least, don't forget to add comment to each new common
> function.  Although it's trivial, the documentation is always better
> to have :)

Good suggestions, thanks! All have been incorporated into the updated
patches.

Thanks,
Fengguang

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2009-11-18  4:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-15 11:32 [PATCH 00/11] Intel HDMI fixes Wu Fengguang
2009-11-15 11:32 ` [PATCH 01/11] intelhdmi - fix audio infoframe fill size Wu Fengguang
2009-11-15 11:32 ` [PATCH 02/11] intelhdmi - fix channel mapping slot mask Wu Fengguang
2009-11-15 11:32 ` [PATCH 03/11] intelhdmi - export monitor-presence and ELD-valid status Wu Fengguang
2009-11-15 11:32 ` [PATCH 04/11] hda - introduce snd_hda_pin_sense() Wu Fengguang
2009-11-15 11:32 ` [PATCH 05/11] intelhdmi - probe for monitor/eld presence at module init time Wu Fengguang
2009-11-15 11:32 ` [PATCH 06/11] intelhdmi - separate out infoframe checksum routine Wu Fengguang
2009-11-15 11:32 ` [PATCH 07/11] intelhdmi - sticky infoframe Wu Fengguang
2009-11-15 11:32 ` [PATCH 08/11] intelhdmi - sticky stream id and format Wu Fengguang
2009-11-15 11:32 ` [PATCH 09/11] intelhdmi - sticky channel count Wu Fengguang
2009-11-15 11:32 ` [PATCH 10/11] hda - show EPSS capability in proc Wu Fengguang
2009-11-15 11:32 ` [PATCH 11/11] intelhdmi - keep power on to avoid losing hot plug event Wu Fengguang
2009-11-15 15:54 ` [PATCH 00/11] Intel HDMI fixes Takashi Iwai
2009-11-18  4:35   ` Wu Fengguang [this message]
2009-11-16 17:12 ` Shane W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118043510.GB8665@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david@hardeman.nu \
    --cc=shane-alsa@csy.ca \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox