Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API
Date: Mon, 30 Nov 2009 12:55:43 +0000	[thread overview]
Message-ID: <20091130125543.GE10968@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1259575964-32251-1-git-send-email-daniel@caiaq.de>

On Mon, Nov 30, 2009 at 11:12:44AM +0100, Daniel Mack wrote:
> This is needed for recent changes in the for-2.6.33 branch.

Which changes?

> -	ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk);
> +	ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk, clk);
>  	if (ret < 0)
>  		return ret;

This looks wrong - why would you configure a PLL to produce the same
frequency as is being input?  I suspect you're trying to update for the
addition of the additional source argument to set_pll()...

  reply	other threads:[~2009-11-30 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 10:12 [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API Daniel Mack
2009-11-30 12:55 ` Mark Brown [this message]
2009-11-30 13:06   ` Daniel Mack
2009-11-30 13:34     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091130125543.GE10968@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@caiaq.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox