From: Daniel Mack <daniel@caiaq.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API
Date: Mon, 30 Nov 2009 14:06:37 +0100 [thread overview]
Message-ID: <20091130130637.GH14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091130125543.GE10968@rakim.wolfsonmicro.main>
On Mon, Nov 30, 2009 at 12:55:43PM +0000, Mark Brown wrote:
> On Mon, Nov 30, 2009 at 11:12:44AM +0100, Daniel Mack wrote:
> > This is needed for recent changes in the for-2.6.33 branch.
>
> Which changes?
snd_soc_dai_set_pll() takes an additional argument now.
>
> > - ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk);
> > + ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk, clk);
> > if (ret < 0)
> > return ret;
>
> This looks wrong - why would you configure a PLL to produce the same
> frequency as is being input? I suspect you're trying to update for the
> addition of the additional source argument to set_pll()...
Ah, right. The pxa-ssp code doesn't pay attention to either argument,
hence I didn't notice. Thanks!
Daniel
>From fdc23d80fa7a3b2aa76e05ee9fbd85dea0f647d8 Mon Sep 17 00:00:00 2001
From: Daniel Mack <daniel@caiaq.de>
Date: Mon, 30 Nov 2009 11:08:17 +0100
Subject: [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API
ALSA's for-2.6.33 branch has a new source argument to
snd_soc_dai_set_pll().
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/pxa/raumfeld.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/pxa/raumfeld.c b/sound/soc/pxa/raumfeld.c
index 5d7bb8c..e713181 100644
--- a/sound/soc/pxa/raumfeld.c
+++ b/sound/soc/pxa/raumfeld.c
@@ -116,7 +116,7 @@ static int raumfeld_cs4270_hw_params(struct snd_pcm_substream *substream,
return ret;
/* setup the CPU DAI */
- ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk);
+ ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, 0, clk);
if (ret < 0)
return ret;
@@ -205,7 +205,7 @@ static int raumfeld_ak4104_hw_params(struct snd_pcm_substream *substream,
return ret;
/* setup the CPU DAI */
- ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk);
+ ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, 0, clk);
if (ret < 0)
return ret;
--
1.6.5.2
next prev parent reply other threads:[~2009-11-30 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 10:12 [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API Daniel Mack
2009-11-30 12:55 ` Mark Brown
2009-11-30 13:06 ` Daniel Mack [this message]
2009-11-30 13:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130130637.GH14091@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox