From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: miguel.aguilar@ridgerun.com
Cc: davinci-linux-open-source@linux.davincidsp.com,
clark.becker@ridgerun.com, santiago.nunez@ridgerun.com,
diego.dompe@ridgerun.com, alsa-devel@alsa-project.org,
nsnehaprabha@ti.com, todd.fischer@ridgerun.com
Subject: Re: [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM
Date: Fri, 8 Jan 2010 11:31:22 +0000 [thread overview]
Message-ID: <20100108113121.GB10128@sirena.org.uk> (raw)
In-Reply-To: <1262902641-14821-1-git-send-email-miguel.aguilar@ridgerun.com>
On Thu, Jan 07, 2010 at 04:17:21PM -0600, miguel.aguilar@ridgerun.com wrote:
> + if (device == 0)
> + davinci_cfg_reg(DM365_EVT2_ASP_TX);
> + else
> + davinci_cfg_reg(DM365_EVT2_VC_TX);
I'd be a bit more comfortable with this if it were using something more
symbolic like a #define or enum rather than checking a bare number to
work out which device it's talking to.
Otherwise this looks good, but I've no familiarity with DaVinci
specifics so...
next prev parent reply other threads:[~2010-01-08 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 22:17 [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM miguel.aguilar
2010-01-08 11:31 ` Mark Brown [this message]
2010-01-08 17:36 ` Miguel Aguilar
2010-01-08 19:37 ` Mark Brown
2010-01-11 15:11 ` Miguel Aguilar
2010-01-11 15:34 ` Mark Brown
2010-01-11 15:53 ` Miguel Aguilar
2010-01-11 16:21 ` Mark Brown
2010-01-19 20:47 ` Miguel Aguilar
2010-01-19 22:10 ` Mark Brown
2010-01-20 14:32 ` Miguel Aguilar
2010-01-20 15:01 ` Mark Brown
2010-01-11 16:04 ` Kevin Hilman
2010-01-11 16:08 ` Miguel Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108113121.GB10128@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=clark.becker@ridgerun.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=diego.dompe@ridgerun.com \
--cc=miguel.aguilar@ridgerun.com \
--cc=nsnehaprabha@ti.com \
--cc=santiago.nunez@ridgerun.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox