issues porting codec to s3c2443

issues porting codec to s3c2443

[Austin, Brian]

Hello,

 

I have forward ported the CS42L52 from 2.6.26.2 to the current asoc git
tree.  The codec and smdk2443-cs42l52 drivers load correctly, at least I
think so, and would like to submit the CS42L52 driver but am having some
issues with s3c2412-i2s.  From my previous kernel version to the latest
there has been significant changes to the S3C architecture and I pretty
sure that I am missing something because of that.  The question is, is
it ok to submit the codec standalone and have someone look at it to make
sure I made the correct changes.  No compiler warnings occur.  My port
was based off of the WM8750 if that helps any

 

Here is the output from my SMDK2443 Simtec

 

Advanced Linux Sound Architecture Driver Version 1.0.18a.

No device for DAI CS42L52

No device for DAI s3c2412-i2s

SMDK2443  cs42l52 ALSA SoC driver ver1.1 10/2008

soc-audio soc-audio: RXEN: Invalid MODE in IISMOD

CS42L52: Cirrus Logic ALSA SoC codec cs42l52 driver verison 1.1 10/2008

ALSA device list:

  No soundcards found.

 

It seems that the S3C2412 I2S is not setup correctly for my platform.

 

Thanks,

Brian Austin

Re: issues porting codec to s3c2443

[Mark Brown]

On Wed, Feb 24, 2010 at 11:43:41AM -0600, Austin, Brian wrote:

> sure that I am missing something because of that.  The question is, is
> it ok to submit the codec standalone and have someone look at it to make
> sure I made the correct changes.  No compiler warnings occur.  My port
> was based off of the WM8750 if that helps any

Yes, it's entirely normal to submit CODEC drivers that aren't referenced
by any machine drivers in mainline - please just go ahead and do this.

> soc-audio soc-audio: RXEN: Invalid MODE in IISMOD

...

> It seems that the S3C2412 I2S is not setup correctly for my platform.

It'd probably be easier for folks to help if you post your machine
driver...

Re: issues porting codec to s3c2443

[Liam Girdwood]

On Wed, 2010-02-24 at 11:43 -0600, Austin, Brian wrote:
> Hello,
> 
>  
> 
> I have forward ported the CS42L52 from 2.6.26.2 to the current asoc git
> tree.  The codec and smdk2443-cs42l52 drivers load correctly, at least I
> think so, and would like to submit the CS42L52 driver but am having some
> issues with s3c2412-i2s.  From my previous kernel version to the latest
> there has been significant changes to the S3C architecture and I pretty
> sure that I am missing something because of that.  The question is, is
> it ok to submit the codec standalone and have someone look at it to make
> sure I made the correct changes.  No compiler warnings occur.  My port
> was based off of the WM8750 if that helps any
> 
>  
> 
> Here is the output from my SMDK2443 Simtec
> 
>  
> 
> Advanced Linux Sound Architecture Driver Version 1.0.18a.
> 
> No device for DAI CS42L52
> 
> No device for DAI s3c2412-i2s
> 
> SMDK2443  cs42l52 ALSA SoC driver ver1.1 10/2008
> 
> soc-audio soc-audio: RXEN: Invalid MODE in IISMOD
> 
> CS42L52: Cirrus Logic ALSA SoC codec cs42l52 driver verison 1.1 10/2008
> 
> ALSA device list:
> 
>   No soundcards found.
> 
>  
> 
> It seems that the S3C2412 I2S is not setup correctly for my platform.
> 

Please do send your codec and machine drivers to the list. This will
make it easier to debug.

Liam 

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: issues porting codec to s3c2443

[Brian Austin]

On Wed, 2010-02-24 at 17:54 +0000, Mark Brown wrote:
> On Wed, Feb 24, 2010 at 11:43:41AM -0600, Austin, Brian wrote:
> 
> > sure that I am missing something because of that.  The question is, is
> > it ok to submit the codec standalone and have someone look at it to make
> > sure I made the correct changes.  No compiler warnings occur.  My port
> > was based off of the WM8750 if that helps any
> 
> Yes, it's entirely normal to submit CODEC drivers that aren't referenced
> by any machine drivers in mainline - please just go ahead and do this.
> 
> > soc-audio soc-audio: RXEN: Invalid MODE in IISMOD
> 
> ...
> 
> > It seems that the S3C2412 I2S is not setup correctly for my platform.
> 
> It'd probably be easier for folks to help if you post your machine
> driver...
> 
I submitted the codec driver today, however with the changes in S3C for
audio, my machine driver panics the kernel.  Once I get that fixed up
I'll submit the machine driver.

Thanks,
Brian

Re: issues porting codec to s3c2443

[Mark Brown]

On Thu, Feb 25, 2010 at 04:10:04PM -0600, Brian Austin wrote:

> I submitted the codec driver today, however with the changes in S3C for
> audio, my machine driver panics the kernel.  Once I get that fixed up
> I'll submit the machine driver.

OK - did you CC myself and Liam on the CODEC driver (please do that for
all ASoC patches - in general you should always CC maintainers on
patches)?  I was going to take a look at it just now but it doesn't seem
to have shown up on the list yet.

Re: issues porting codec to s3c2443

[Mark Brown]

On Thu, Feb 25, 2010 at 05:48:17PM -0600, Brian Austin wrote:

> The alsa-devel put the patch on hold till the moderator approves it.
> So it says

Ah, probably too large.  Could you please resend with the CCs -
sometimes the moderators are busy for a few days.

Re: issues porting codec to s3c2443

[Brian Austin]

On Thu, 2010-02-25 at 23:09 +0000, Mark Brown wrote:
> On Thu, Feb 25, 2010 at 04:10:04PM -0600, Brian Austin wrote:
> 
> > I submitted the codec driver today, however with the changes in S3C for
> > audio, my machine driver panics the kernel.  Once I get that fixed up
> > I'll submit the machine driver.
> 
> OK - did you CC myself and Liam on the CODEC driver (please do that for
> all ASoC patches - in general you should always CC maintainers on
> patches)?  I was going to take a look at it just now but it doesn't seem
> to have shown up on the list yet.
> 

No, I didnt CC you guys.  I'll do that from now on.

The alsa-devel put the patch on hold till the moderator approves it.
So it says

Brian