From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Phil Edworthy <Phil.Edworthy@renesas.com>
Subject: Re: [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support
Date: Tue, 9 Mar 2010 13:38:04 +0000 [thread overview]
Message-ID: <20100309133803.GB1940@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <ufx4amigj.wl%morimoto.kuninori@renesas.com>
On Tue, Mar 02, 2010 at 05:13:50PM +0900, Kuninori Morimoto wrote:
> + /* Disable active mode */
> + snd_soc_update_bits(codec, DA7210_STARTUP1, DA7210_SC_MST_EN, 0);
> +
> snd_soc_update_bits(codec, hpf_reg, hpf_mask, hpf_value);
> snd_soc_update_bits(codec, DA7210_PLL, DA7210_PLL_FS_MASK, fs);
> + snd_soc_update_bits(codec, DA7210_PLL_DIV3, DA7210_PLL_BYP, bypass);
This will take effect for both playback and capture - what happens if
one mode wants bypass and another doesn't? Does the device actually
support asymmetric sample rates?
> + /* As suggested by Dialog */
> + da7210_write(codec, DA7210_A_HID_UNLOCK, 0x8B);
> + da7210_write(codec, DA7210_A_TEST_UNLOCK, 0xB4);
> + da7210_write(codec, DA7210_A_PLL1, 0x01);
> + da7210_write(codec, DA7210_A_CP_MODE, 0x7C);
I suspect you want to disable the HID and test keys when you're done
fiddling with the configuration here...
next prev parent reply other threads:[~2010-03-09 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 8:13 [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support Kuninori Morimoto
2010-03-09 13:38 ` Mark Brown [this message]
2010-03-10 2:45 ` Kuninori Morimoto
2010-03-10 10:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309133803.GB1940@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Phil.Edworthy@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=morimoto.kuninori@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox