From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support
Date: Wed, 10 Mar 2010 10:06:20 +0000 [thread overview]
Message-ID: <20100310100619.GA24422@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <uy6i0hp27.wl%morimoto.kuninori@renesas.com>
On Wed, Mar 10, 2010 at 11:45:52AM +0900, Kuninori Morimoto wrote:
> This chip doesn't support asymmetric sample rates.
> Is there a method of prohibiting it on ALSA ?
> Or should I add any lock ?
Set symmetric_rates in the DAI.
> > > + /* As suggested by Dialog */
> > > + da7210_write(codec, DA7210_A_HID_UNLOCK, 0x8B);
> > > + da7210_write(codec, DA7210_A_TEST_UNLOCK, 0xB4);
> > > + da7210_write(codec, DA7210_A_PLL1, 0x01);
> > > + da7210_write(codec, DA7210_A_CP_MODE, 0x7C);
> > I suspect you want to disable the HID and test keys when you're done
> > fiddling with the configuration here...
> Ohh sorry.
> This XXX_UNLOCK doesn't mean "disable"..
> In default, we can not change value on some register
> because it is locked.
> So, this driver unlock it here.
> Should I add some comment ?
No, what I'm saying is that since the registers are supposed to be
locked in normal operation you should reset the lock registers so that
unintended register writes don't occur in normal operation. The locks
will cover more than you're updating here.
prev parent reply other threads:[~2010-03-10 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 8:13 [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support Kuninori Morimoto
2010-03-09 13:38 ` Mark Brown
2010-03-10 2:45 ` Kuninori Morimoto
2010-03-10 10:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310100619.GA24422@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=morimoto.kuninori@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).