Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Olaya, Margarita" <magi.olaya@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains
Date: Tue, 7 Dec 2010 13:36:49 +0000	[thread overview]
Message-ID: <20101207133649.GV4698@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCEA4CFBCD5@dlee06.ent.ti.com>

On Mon, Dec 06, 2010 at 06:18:23PM -0600, Olaya, Margarita wrote:
> Some gains were incorrectly configured for dB values.
> 
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

but:

>  /*
>   * AFMGAIN volume control:
>   * from 18 to 24 dB in 6 dB steps
>   */
> -static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 600, 600, 0);
> +static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 1800, 600, 0);

this was only added earlier in the series - please fix up the original
patch if resubmitting.

      reply	other threads:[~2010-12-07 13:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07  0:18 [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains Olaya, Margarita
2010-12-07 13:36 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101207133649.GV4698@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=magi.olaya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox