* [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains
@ 2010-12-07 0:18 Olaya, Margarita
2010-12-07 13:36 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Olaya, Margarita @ 2010-12-07 0:18 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel@alsa-project.org
Some gains were incorrectly configured for dB values.
Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>
---
sound/soc/codecs/twl6040.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index 9b12219..feba59d 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -911,15 +911,15 @@ static DECLARE_TLV_DB_SCALE(mic_preamp_tlv, -600, 600, 0);
/*
* MICGAIN volume control:
- * from 6 to 30 dB in 6 dB steps
+ * from -6 to 30 dB in 6 dB steps
*/
-static DECLARE_TLV_DB_SCALE(mic_amp_tlv, 600, 600, 0);
+static DECLARE_TLV_DB_SCALE(mic_amp_tlv, -600, 600, 0);
/*
* AFMGAIN volume control:
* from 18 to 24 dB in 6 dB steps
*/
-static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 600, 600, 0);
+static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 1800, 600, 0);
/*
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains
2010-12-07 0:18 [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains Olaya, Margarita
@ 2010-12-07 13:36 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2010-12-07 13:36 UTC (permalink / raw)
To: Olaya, Margarita; +Cc: alsa-devel@alsa-project.org, Liam Girdwood
On Mon, Dec 06, 2010 at 06:18:23PM -0600, Olaya, Margarita wrote:
> Some gains were incorrectly configured for dB values.
>
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but:
> /*
> * AFMGAIN volume control:
> * from 18 to 24 dB in 6 dB steps
> */
> -static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 600, 600, 0);
> +static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 1800, 600, 0);
this was only added earlier in the series - please fix up the original
patch if resubmitting.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-07 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-07 0:18 [PATCH 15/15] ASoC: twl6040: Fix TLV dB step values for gains Olaya, Margarita
2010-12-07 13:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox