Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Dong Aisheng <b29396@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	s.hauer@pengutronix.de, lrg@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/1] ASoC: mxs-saif: add record function
Date: Fri, 9 Sep 2011 15:30:51 +0200	[thread overview]
Message-ID: <20110909133051.GS1912@pengutronix.de> (raw)
In-Reply-To: <1315399910-6525-1-git-send-email-b29396@freescale.com>


[-- Attachment #1.1: Type: text/plain, Size: 2216 bytes --]

On Wed, Sep 07, 2011 at 08:51:50PM +0800, Dong Aisheng wrote:
> 1. add different clkmux mode handling
> SAIF can use two instances to implement full duplex (playback &
> recording) and record saif may work on EXTMASTER mode which is
> using other saif's BITCLK&LRCLK.
> 
> The clkmux mode could be set in pdata->init() in mach-specific code.
> For generic saif driver, it only needs to know who is his master
> and the master id is also provided in mach-specific code.
> 
> 2. support playback and capture simutaneously however the sample
> rates can not be different due to hw limitation.
> 
> Signed-off-by: Dong Aisheng <b29396@freescale.com>

One thing I see...

> @@ -422,20 +503,39 @@ static int mxs_saif_trigger(struct snd_pcm_substream *substream, int cmd,
>  			__raw_readl(saif->base + SAIF_DATA);
>  		}
>  
> -		dev_dbg(cpu_dai->dev, "CTRL 0x%x STAT 0x%x\n",
> +		master_saif->ongoing = 1;
> +
> +		dev_dbg(saif->dev, "CTRL 0x%x STAT 0x%x\n",
>  			__raw_readl(saif->base + SAIF_CTRL),
>  			__raw_readl(saif->base + SAIF_STAT));
>  
> +		dev_dbg(master_saif->dev, "CTRL 0x%x STAT 0x%x\n",
> +			__raw_readl(master_saif->base + SAIF_CTRL),
> +			__raw_readl(master_saif->base + SAIF_STAT));
>  		break;
>  	case SNDRV_PCM_TRIGGER_SUSPEND:
>  	case SNDRV_PCM_TRIGGER_STOP:
>  	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>  		dev_dbg(cpu_dai->dev, "stop\n");
>  
> -		clk_disable(saif->clk);
> -		if (!saif->mclk_in_use)
> +		/* wait a while for the current sample to complete */
> +		delay = USEC_PER_SEC / master_saif->cur_rate;
> +
> +		if (!master_saif->mclk_in_use) {
> +			__raw_writel(BM_SAIF_CTRL_RUN,
> +				master_saif->base + SAIF_CTRL + MXS_CLR_ADDR);
> +			udelay(delay);
> +		}
> +		clk_disable(master_saif->clk);
> +
> +		if (saif != master_saif) {
>  			__raw_writel(BM_SAIF_CTRL_RUN,
>  				saif->base + SAIF_CTRL + MXS_CLR_ADDR);
> +			udelay(delay);

I think we should use usleep_range for both udelays here? Having a rate
of 8000, we'd burn 250us here.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  parent reply	other threads:[~2011-09-09 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 12:51 [PATCH v3 1/1] ASoC: mxs-saif: add record function Dong Aisheng
2011-09-08 21:29 ` Girdwood, Liam
2011-09-08 21:42   ` Wolfram Sang
2011-09-16  2:53   ` Dong Aisheng
2011-09-16  8:54     ` Mark Brown
2011-09-09 13:30 ` Wolfram Sang [this message]
2011-09-15 13:06   ` Dong Aisheng-B29396
2011-09-15 13:53     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110909133051.GS1912@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=b29396@freescale.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lrg@ti.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox