Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Dong Aisheng-B29396 <B29396@freescale.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"lrg@ti.com" <lrg@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/1] ASoC: mxs-saif: add record function
Date: Thu, 15 Sep 2011 15:53:20 +0200	[thread overview]
Message-ID: <20110915135320.GG2284@pengutronix.de> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F77225DB00@039-SN1MPN1-003.039d.mgd.msft.net>


[-- Attachment #1.1: Type: text/plain, Size: 825 bytes --]


> > I think we should use usleep_range for both udelays here? Having a rate
> > of 8000, we'd burn 250us here.
> >
> Yes, I agree that it's a bit long for 8000.
> I tried sleep way but I found the trigger function is called with
> spin_lock held, so it seems we may not be able to sleep here.
> 
> I think the way of dynamically calculate delay suggested by Liam has
> Already minimize the affection, especially for high sample rate, it
> may work more efficiency than sleep (context switch cost).
> 
> Do you think if it's reasonable to accept it?

Yes, it can be fixed when it becomes necessary

Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2011-09-15 13:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 12:51 [PATCH v3 1/1] ASoC: mxs-saif: add record function Dong Aisheng
2011-09-08 21:29 ` Girdwood, Liam
2011-09-08 21:42   ` Wolfram Sang
2011-09-16  2:53   ` Dong Aisheng
2011-09-16  8:54     ` Mark Brown
2011-09-09 13:30 ` Wolfram Sang
2011-09-15 13:06   ` Dong Aisheng-B29396
2011-09-15 13:53     ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110915135320.GG2284@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=B29396@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lrg@ti.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox