From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: alsa-devel@alsa-project.org, Andrey Danin <danindrey@mail.ru>,
lrg@ti.com
Subject: Re: [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes.
Date: Mon, 14 Nov 2011 21:39:16 +0000 [thread overview]
Message-ID: <20111114213915.GH6528@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1321213993-27920-1-git-send-email-leon@leon.nu>
On Sun, Nov 13, 2011 at 09:53:13PM +0200, Leon Romanovsky wrote:
> - SOC_DOUBLE_TLV("Line Playback Volume",
> + SOC_DOUBLE_TLV("Speaker Playback Volume",
> ALC5632_SPK_OUT_VOL, 8, 0, 31, 1, hp_tlv),
This looks really suspicious, why are we renaming the line output as a
speaker output? This might be appropriate on your board but if the
drivers aren't part of the CODEC it might not be appropriate on another
board.
> ALC5632_LINE_IN_VOL, 8, 0, 31, 1, vol_tlv),
> - SOC_DOUBLE_TLV("Stereo DAC Playback Volume",
> + SOC_DOUBLE_TLV("Master Playback Volume",
> ALC5632_STEREO_DAC_IN_VOL, 8, 0, 63, 1, vdac_tlv),
> - SOC_DOUBLE("Stereo DAC Playback Switch",
> + SOC_DOUBLE("Master Playback Switch",
This looks fine.
next prev parent reply other threads:[~2011-11-14 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 19:53 [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes Leon Romanovsky
2011-11-14 21:39 ` Mark Brown [this message]
2011-11-14 21:50 ` Leon Romanovsky
2011-11-15 19:25 ` Mark Brown
2011-11-16 5:18 ` Leon Romanovsky
2011-11-16 10:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114213915.GH6528@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=danindrey@mail.ru \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox