From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: alsa-devel@alsa-project.org, Andrey Danin <danindrey@mail.ru>,
lrg@ti.com
Subject: Re: [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes.
Date: Tue, 15 Nov 2011 19:25:10 +0000 [thread overview]
Message-ID: <20111115192509.GA4223@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CALq1K=+gUXnt0q4TxpUOhZFmdnHd+jdnkMpbj0JpF7_BkpCiDg@mail.gmail.com>
On Mon, Nov 14, 2011 at 11:50:05PM +0200, Leon Romanovsky wrote:
> On Mon, Nov 14, 2011 at 23:39, Mark Brown
> > This looks really suspicious, why are we renaming the line output as a
> > speaker output? This might be appropriate on your board but if the
> > drivers aren't part of the CODEC it might not be appropriate on another
> > board.
> There are two main reasons:
> 1) We are changing SPK_OUT_VOL which on the schematics marked as a
> speaker, and we want to be as close as possible to the datasheet.
> 2) We are tired to explain to users that the speaker volume controlled
> by "Line Playback Volume" in alsamixer.
The above both sound board specific. What does the CODEC itself call
these outputs?
next prev parent reply other threads:[~2011-11-15 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 19:53 [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes Leon Romanovsky
2011-11-14 21:39 ` Mark Brown
2011-11-14 21:50 ` Leon Romanovsky
2011-11-15 19:25 ` Mark Brown [this message]
2011-11-16 5:18 ` Leon Romanovsky
2011-11-16 10:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115192509.GA4223@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=danindrey@mail.ru \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox