Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* smatch stuff in new Cirrus Logic CS42L73 driver
@ 2011-11-18  8:39 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-11-18  8:39 UTC (permalink / raw)
  To: Brian Austin; +Cc: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 642 bytes --]

Hi Brian,

Smatch complains about some stuff in sound/soc/codecs/cs42l73.c.  I
don't know the code well enough to say what was intended.

sound/soc/codecs/cs42l73.c +1030 cs42l73_set_dai_fmt(53) error: inv is never equal to 1024 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1032 cs42l73_set_dai_fmt(55) error: inv is never equal to 768 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1036 cs42l73_set_dai_fmt(59) error: inv is never equal to 1024 (wrong type 0 - 255).
sound/soc/codecs/cs42l73.c +1105 cs42l73_pcm_hw_params(18) info: why not propagate 'mclk_coeff' from cs42l73_get_mclk_coeff() instead of -22?

regards,
dan carpenter

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-11-18  8:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18  8:39 smatch stuff in new Cirrus Logic CS42L73 driver Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox