From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org,
Sven Neumann <s.neumann@raumfeld.com>,
timur@freescale.com, lrg@ti.com
Subject: Re: [PATCH] ALSA: ASoC: cs4720: use snd_soc_cache_sync()
Date: Tue, 22 Nov 2011 16:08:42 +0000 [thread overview]
Message-ID: <20111122160842.GD30583@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4ECBC81E.6030300@gmail.com>
On Tue, Nov 22, 2011 at 05:04:46PM +0100, Daniel Mack wrote:
> On 11/22/2011 04:53 PM, Mark Brown wrote:
> > Could be, though I can't see any changes in the code here. It might be
> > that a change between SMBus and regmap at runtime is upsetting the
> > device somehow but given that it's supposed to be coming back from a
> > power on reset...
> That should affect more codecs then, right?
> $ git grep -l i2c_smbus_write sound/
> sound/aoa/codecs/onyx.c
> sound/aoa/codecs/tas.c
> sound/ppc/daca.c
> sound/ppc/tumbler.c
> sound/soc/codecs/tpa6130a2.c
None of these use regmap so wouldn't be affected by an interaction
between the two. The tpa6130a2 isn't going through the standard ASoC
structures at all.
> > Does reverting to the non-regmap soc-io.c help?
> Is there a single commit we can revert on top of 3.2-git to test this?
Should be, or a small series anyway. git log sound/soc/soc-io.c should
show.
prev parent reply other threads:[~2011-11-22 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:45 [PATCH] ALSA: ASoC: cs4720: use snd_soc_cache_sync() Daniel Mack
2011-11-22 14:02 ` Mark Brown
2011-11-22 15:23 ` Daniel Mack
2011-11-22 15:35 ` Mark Brown
2011-11-22 15:37 ` Timur Tabi
2011-11-22 15:41 ` Daniel Mack
2011-11-22 15:43 ` Mark Brown
2011-11-22 15:44 ` Daniel Mack
2011-11-22 15:47 ` Timur Tabi
2011-11-22 15:57 ` Daniel Mack
2011-11-22 16:12 ` Timur Tabi
2011-11-22 15:53 ` Mark Brown
2011-11-22 16:04 ` Daniel Mack
2011-11-22 16:08 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122160842.GD30583@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=s.neumann@raumfeld.com \
--cc=timur@freescale.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox